Re: RFS: New dnstwist upstream version and bug fix (was: Test suite issue fixed for dnstwist)
Hi Samuel,
Samuel Henrique <samueloph@debian.org> 於 2020年5月3日 週日 下午9:35寫道：
>
> Hello Peter and SZ Lin,
>
> > > Can you send the MR to the team repository[1]?
> > >
> > > [1] https://salsa.debian.org/pkg-security-team/dnstwist
> >
> > what precisely do you want me to do? Usually a MR relates one source
> > branch to one destination branch. But the mentioned changes affect three
> > branches and a tag. How am I supposed to map this to a normal MR?
>
> Peter, I noticed you are the maintainer of the package and is also a
> DM, so I gave you permission to the repository, maintainers should be
> able to push to their packages' repos.
> I also pushed all your changes to the team's repo, so from now on
> please feel free to commit there directly. I hope this reduces the
> overhead of contributing for you.
>
> SZ Lin, one thing I usually do when reviewing things like this is, I
> review the changes on the person's fork and then push them to the
> official repo when done. an MR might help, but as Peter mentioned, is
> only doable when only one branch has changes.
Thanks for taking this, I'm on the national holidays.
According to the team wiki [1], it elaborates to submit merge requests to
submit the result of the work in most cases.
Therefore, generally, I review the MR which includes three branches in
Salsa once the repository exists in the team.
IIRC, the MR function in Salsa will handle three different branches
and act accordingly.
(please correct me if I'm wrong)
[1] https://wiki.debian.org/Teams/pkg-security
SZ
>
> We are already 7 days after Peter's initial request for review, so if
> nobody beats me to it, I will do it tomorrow.
>
> Regards,
>
> --
> Samuel Henrique <samueloph>
Reply to: