Re: DD Ping - New ncrack package

[Samuel Henrique <samueloph@debian.org>]

Hello Marcos,

Hmm, I'm kinda wary of the patch you picked[0], it has not been
reviewed by upstream yet and it's removing the variable definition
instead of making use of a declaration with "external" on the other
instance, that's also not what Arch is doing[1] (submitter mentions
that they found the issue on Arch).

Are you confident that this fix won't introduce any issues and have
you considered instead to fix it by making use of the "-fcommon"
CFLAG[2]?

[0] https://github.com/nmap/ncrack/pull/83
[1] https://github.com/archlinux/svntogit-community/tree/packages/ncrack/trunk
[2] https://gcc.gnu.org/gcc-10/porting_to.html#common

Thanks,


--
Samuel Henrique <samueloph>