Re: MRs on salsa and letting janitor automate things
Hello Stuart,
thanks for the information! I am personally OK with the idea of committing
directly to the Science packages, not sure about the opinions of other
team members.
But if it improves the overall package quality - I am totally for this.
Otherwise, I did not find an opportunity to blacklist some packages
for the janitor, not being touched by this tool. There are some difficult
ones, so I would prefer to have this option. Do you know, whether
it is possible?
Thanks!
Anton
Am So., 27. Nov. 2022 um 06:02 Uhr schrieb Stuart Prescott <stuart@debian.org>:
>
> Hi folks
>
> tl;dr: there lots of untriaged MRs on salsa; let's permit Janitor to
> automatically commit its updates
>
>
> There are lots of MRs on salsa for science-team packages that are open.
> Many of these have been open for months and many have no comments,
> triage or feedback visible on salsa. Many of these have been made by
> first time contributors who, by virtue of their MRs sitting
> unacknowledged and unmerged for months, think we don't care. That's not
> our intended message!
>
> Attached are:
>
> * a list of MRs that are currently open on salsa (sorted by package)
>
> * associated dd-list of maintainers/uploaders for these packages
>
> If you don't currently get notified about MRs being opened for packages
> you are interested in, I encourage you to tweak your salsa notification
> preferences. My approach to this is to "star" packages for which I am
> maintainer, uploader, or otherwise interested enough in that I'd like to
> see notifications for MRs.
>
>
> In amongst the human-generated MRs, there was also a huge number of
> automated MRs from the Janitor bot. Over the last couple of days I've
> been through Janitor's MRs (about 200 of them). These are all really
> simple changes, each of which I checked and almost all of them I have
> merged.
>
> For those not familiar with Janitor, it looks for easy to fix issues in
> the packaging that are flagged by lintian (or other similar tools) and
> fixes them. Unlike lintian, it has internet access and knowledge of the
> Debian archive, so it can do extra things like update upstream homepages
> or remove obsolete version constraints on packages. Janitor's fixes
> range from pedantic to very useful; even the more pedantic ones steadily
> improve the signal:noise of lintian and so lintian becomes more useful
> on those packages.
>
> https://janitor.debian.net/
>
> I propose that we let Janitor make these commits directly rather than
> opening MRs; quite a few other teams in Debian have done this and it is
> working well. Janitor has proven itself to be reliable and useful. Since
> we've now been able to see that Janitor's changes are OK for a few
> years, we can safely cut out the manual work and just let the bot get on
> with its work. Comments?
>
> regards
> Stuart
>
> --
> Stuart Prescott http://www.nanonanonano.net/ stuart@nanonanonano.net
> Debian Developer http://www.debian.org/ stuart@debian.org
> GPG fingerprint 90E2 D2C1 AD14 6A1B 7EBB 891D BBC1 7EBB 1396 F2F7
Reply to: