[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFS] seaborn





On Thu, 27 Feb 2020 at 03:51, Christian Kastner <ckk@debian.org> wrote:
Hi Nilesh,

On 26.02.20 11:14, Nilesh Patra wrote:
> Hi,
> currently seaborn FTBFS as indicated on the tracker as well.
> I have fixed it; build and autopkgtests pass.
> I have pushed my changes to the team repo here[1].
> Needs review and sponsorship.
>
> [1]: https://salsa.debian.org/science-team/seaborn

looks good! Built without issues on my side, and lintian clean.

Regarding debian/changelog, there's a stray parenthesis at the end of
the line Closing: the bugs. Can you either remove it, or add the opening
one, lest the bug scanner gets thrown off during parsing?

Oops! Fixed now, and pushed.


This is just cosmetic and doesn't need fixing now, but when updating
patches after new releases, it's customary to just add the phrase
"Refresh patches".


Aha, alrighty. I have noted this, and will incorporate in future - if it doesn't need fixing right now, could you please review if everything looks okay, and sponsor an upload if possible?
That would be great.

Thanks

Reply to: