Re: RFS: python-fluids/0.1.72-1
Hello Kurt,
thanks for your contribution. I have uploaded your package.
Please move the repo into the debian-science team on salsa.
I have gave you developer-permissions for the next two weeks.
Please let me know whether it is enough for you.
Also please apply the attached patch.
Autopkgtests are OK for now, but consider to add a couple of
more complex ones to test the basic functionality for the package.
Best regards
Anton
2018-06-19 14:36 GMT+02:00 Kurt Kremitzki <kkremitzki@gmail.com>:
> On Thu, May 17, 2018 at 5:17 PM, Anton Gladky <gladk@debian.org> wrote:
>> Hi Kurt,
>>
>> the package looks good. Some minor notes/questions:
>>
>> - Should the package be moved into the science-team repo?
>
> Yes, it should. Also, I have several new packages I plan on packaging
> under the Science Team. Would it be possible for me to get the rights
> to create repos there?
>
>> - Are you sure you need so mane build-depends packages to build
>> python-fluids? Should they not be in the Depends section?
>
> I moved a few dependencies over into plain Depends, but most of the
> B-D packages are required for the test stage of the build.
>
>> - Please add a couple of autopkgtests (dep8) to check the basic
>> functionality of the package continuously.
>
> I added a very basic autopkgtest but this part of packaging is new to
> me. Are there any others you'd suggest adding besides [1]?
>
>> - Looks like the md5sum of the tarball in the pristine-tar does not
>> match to the file, downloaded by uscan. Could you please check?
>
> I think I had just forgotten to push the branch, but since it took me
> so long to get back to this email I've forgotten if I fixed this.
> Regardless a fresh clone and build seems OK so if this persists just
> let me know how to reproduce it.
>
>> - There are two important lintian warnings:
>> W: python-fluids-doc: empty-binary-package
>> W: python-fluids: new-package-should-not-package-python2-module
>> python-fluids
>
> I've taken care of both of these as well. For the Python 2 warning, I
> just included a note in the changelog stating both 2 & 3 are provided.
> This library is a dependency for both a thermo and heat transfer
> Python library I am working towards packaging, and while everything
> should be fine in 3, I'd prefer to include both versions and then just
> remove 2 when the time comes.
>
>> - Please double-check all files and their licenses, whether they are mirrored
>> in d/copyright.
>>
>
> Done.
>
> [1] https://salsa.debian.org/kkremitzki-guest/python-fluids/blob/master/debian/tests/control
From 6f12f081d90a81f38fceca73afc3d0c08d64aa2f Mon Sep 17 00:00:00 2001
From: Anton Gladky <gladk@debian.org>
Date: Sat, 23 Jun 2018 21:17:46 +0200
Subject: [PATCH] Add tilda to the debhelper vesion
---
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index d5e5ae2..aa801a0 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: python
Priority: optional
Maintainer: Debian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org>
Uploaders: Kurt Kremitzki <kkremitzki@gmail.com>
-Build-Depends: debhelper (>= 11),
+Build-Depends: debhelper (>= 11~),
pandoc,
dh-python,
python-all,
--
2.17.1
Reply to: