[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: autodep8 for R packages?



On Sun, Apr 10, 2016 at 12:42:13PM +0200, Gordon Ball wrote:
> I have written a patch[1] for autodep8 which generates implicit
> `library(foo)` tests for R packages.
> 
> If I understand the current ci.debian.net set-up correctly, this would
> then be used for any matching[2] packages which don't have their own
> specific test configuration.
> 
> Are there any serious objections to forwarding this to autodep8? (No
> guarantee they'd accept it, of course)

Hmm, I tried to inspect your actual code in the web view[3] but this
returns 403. :-(

So no objections in principle if the code ensures that the more detailed
test that might be contained inside the package will not be overriden by
this simple test.
 
As an enhancement I would suggest to detect what test suite of R
packages might be used by the package (testthat, ...) and run this one.
This might enable more sophisticated testing.

Kind regards

      Andreas.

PS: BTW, I'd consider the Build-Time tests (see #752609) as similarly
important to CI tests.

> [1]: https://git.chronitis.net/autodep8.git/rrequire/
> [2]: Packages are matched by source name /^r-/ and having a
> ./DESCRIPTION file
[3] https://git.chronitis.net/autodep8.git/blob/rrequire/test/r_test.sh

-- 
http://fam-tille.de


Reply to: