Re: abinit

[Michael Banck <mbanck@debian.org>]

Hi,

On Tue, Apr 10, 2012 at 12:50:41AM +0000, Ólafur Jens Sigurðsson wrote:
> Uploaded another package that is in better shape then the original,
> the only lintian complaint is about binaries with no man pages.
> 
> This one is not dfsg since I did not remove any files to make it
> debian complient, the reason for those removals have been addressed
> upstream.
> 
> Please have a look at tell me if it is good enough, the path is again
> http://ojs.klaki.net/debian/abinit (its a friends server, doesn't have
> a super fast connection so be patient).

I am a bit confused about those files.  There is a
abinit-6.12.2.orig.tar.gz  upstream tarball, but all the .dsc files only
reference native .tar.gz files.  Also, note that the versions of the
.dsc are "6.2.12" not "6.12.2", which one is it?

Some other comments:

1. The changelog is malformed, there must(?) be an empty newline between
the last changelog item and the entry footer.

2. The source package situation could be better explained, "Package is
no longer dfsg, source for documentation is provided" was not very clear
to me.  Maybe "Drop dfsg from upstream version number as the offending
issues have been addressed".

3. Likewise for "so it doesn't pull in extra libs", I believe you mean
the build process would otherwise download some packages during
configure and/or build time and use them.  I suggest "so no external
libraries are downloaded and built during configure/build" or so.


Michael