[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: RSL - Radar Software Library



On 2011-07-26 19:23, Julian Taylor wrote:
> It does not build in a clean chroot, it is missing a lexer build dependency, e.g. flex should do:
> 
> libtool: link: gcc -g -O2 -Wl,-Bsymbolic-functions -o any_to_gif any_to_gif.o  -L/usr/lib ../.libs/librsl.a /usr/lib/libmfhdf.so /usr/lib/libdf.so /usr/lib/x86_64-linux-gnu/libjpeg.so -lz -lm
> ../.libs/librsl.a(rapic.o): In function `rapicwrap':
> /rsl/rapic.y:622: undefined reference to `yywrap'

Added flex dependency and build using pbuilder.


> please fix this lintian error:
> E: librsl-dev: non-empty-dependency_libs-in-la-file usr/lib/librsl.la
> You can probably just remove the la file
> see http://wiki.debian.org/ReleaseGoals/LAFileRemoval

Fixed by removing .la files from librsl-dev.install.


> debian/rules:
>  dh --with autoreconf $@
> should be
>  dh $@ --with autoreconf

Fixed.


> some of the changes debian/patches/rsl-automake.patch seem suspicious
> if they have a reason please document it using dep3 guidelines
> http://dep.debian.net/deps/dep3/
> e.g.
> -#define COLORDIR "/usr/local/trmm/GVBOX/lib/colors"
> +#define COLORDIR DATADIR "/colors"
> or
> -#define WSR88D_SITE_INFO_FILE "/usr/local/trmm/GVBOX/lib/wsr88d_locations.dat"
> +#define WSR88D_SITE_INFO_FILE DATADIR "/wsr88d_locations.dat"
> 
> also the reindenting of the color macros is unnecessary in a patch.

Some of that is because it was originally a patch I submitted upstream.
I can trim down some of it if necessary, but some off it is needed to
work with newer version of automake.

Attachment: pgp3AiDoJFMlM.pgp
Description: PGP signature


Reply to: