[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: viennacl



Hi Michael,

[...]

I've taken another look at viennacl and it looks mostly fine, except for:

- debian/watch as-is considers ViennaCL-matlab-*, which it shouldn't do. I'd
  change the regexp to http://sf.net/viennacl/ViennaCL-(\d.*)\.tar\.gz
- auxiliary/converter is shipped as binary, although converter.cpp probably is
  its source!?
- all of viennacl/ could probably be generated at build time, using the above
  converter.
- doxygen could easily be run at build time.
- debian/copyright is missing information for
  * external/pugixml/*
  * CL/*

Please fix these (the latter is essential), then your package should be ready to
be uploaded!

Thanks a lot for your work,
Michael

Attachment: pgpJxObLs8fD6.pgp
Description: PGP signature


Reply to: