On 07/26/2011 10:50 AM, Andy Spencer wrote: > I am looking for a sponsor for my package "Grits". > > * Package name : grits > Version : 0.5 > Upstream Author : Andy Spencer (myself) > * URL : http://lug.rose-hulman.edu/proj/aweather/grits > * License : GPL-3+ > Programming Lang: C > Description : A Virtual Globe library > > Grits is a "Virtual Globe" library which uses OpenGL to render an image > of the earth using satellite and terrain data from publicly accessible > servers. This is similar in concept to Google Earth and NASA World > Wind, except implemented as a library. > > > The package appears to be lintian clean. > > Further information about the Debian package can be found here: > > Debian Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603393 > Git Repo: git://git.debian.org/pkg-grass/grits.git > Gitweb: http://git.debian.org/?p=pkg-grass/grits.git Hi, I can't sponsor your package, but I have some comments: it does not build in a clean pbuilder environment: ../../doltcompile gcc -DHAVE_CONFIG_H -I. -I../.. -Wall --std=gnu99 -I../../src -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/atk-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -pthread -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -fPIC -g -O2 -c -o grits-object.lo grits-object.c grits-object.c:33:19: fatal error: GL/gl.h: No such file or directory .. grits-poly.c:27:20: fatal error: GL/glu.h: No such file or directory ... if that is fixed: gcc: error: unrecognized option '--as-needed' you are patching Makefile.am but not regenerating it, use dh $@ --with autoreconf (+ a build depend on dh-autoreconf) or patch Makefile.in debian/copyright: Files: is a required DEP5 tag, add a Files: * if the copyright covers all files debian/watch: the regex is probably a bit to generic http://lug.rose-hulman.edu/proj/grits/libgis-([\d.]+)\.tar\.gz may be better some shlibs warnings: dpkg-shlibdeps: warning: debian/libgrits0/usr/lib/grits0/test.so contains an unresolvable reference to symbol g_type_check_class_cast: it's probably a plugin. dpkg-shlibdeps: warning: 11 other similar warnings have been skipped (use -v to see them all). dpkg-shlibdeps: warning: debian/libgrits0/usr/lib/grits0/map.so contains an unresolvable reference to symbol glGenTextures: it's probably a plugin. dpkg-shlibdeps: warning: 39 other similar warnings have been skipped (use -v to see them all). dpkg-shlibdeps: warning: debian/libgrits0/usr/lib/grits0/sat.so contains an unresolvable reference to symbol glGenTextures: it's probably a plugin. dpkg-shlibdeps: warning: 39 other similar warnings have been skipped (use -v to see them all). dpkg-shlibdeps: warning: debian/libgrits0/usr/lib/grits0/env.so contains an unresolvable reference to symbol glGenTextures: it's probably a plugin. dpkg-shlibdeps: warning: 27 other similar warnings have been skipped (use -v to see them all). dpkg-shlibdeps: warning: debian/libgrits0/usr/lib/grits0/elev.so contains an unresolvable reference to symbol g_free: it's probably a plugin. dpkg-shlibdeps: warning: 20 other similar warnings have been skipped (use -v to see them all). If they aren't plugins they shuold link against what they need to not create problems in --as-needed builds. optional: even with the as-needed there seems to be some unnecessary linkage, is the flag used correctly (its positional)? multiarch is now possible in debian. Consider enabling a multiarch build: http://wiki.debian.org/Multiarch/Implementation run wrap-and-sort from ubuntu-dev-tools for some nice formating of debian/ Best Regards, Julian Taylor
Attachment:
signature.asc
Description: OpenPGP digital signature