[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFC: Revoke membership for janitor bot



On Fri, Oct 01, 2021 at 03:34:22PM +0530, Pirate Praveen wrote:
> 
> 
> On 1 October 2021 7:30:23 am IST, Daniel Leidert <dleidert@debian.org> wrote:
> >Hi there,
> >
> >most of you know that janitor/jenkins is committing to our repositories
> >directly. However, I recently saw that it starts to commit changes targetted at
> >buid-dependencies purely based on the fact that lintian might complain, and it
> >also raises the standards version. IMHO these are tasks that only the
> >maintainer should do. I have serious doubts about raising the debhelper version
> >automatically because it changes debhelper's behavior (and can change package
> >contents or maintainer script behavior) and it also raises the requirements
> >which are then no longer been fulfilled by oldstable (has debhelper 12). I
> >don't want the debhelper level to be raised automatically because I'm still
> >trying to support buster-backports and I like having to do as few changes as
> >possible to prepare backports. So it is a conscious decision to stay with
> >debhelper 12 in some of my packages at the moment.
> 
> I think janitor checks if the deb contents changed using diffoscope. I
> think this is useful activity and helps us in not bothering to spend
> time on routine tasks.
> 
> >I suggest to remove the commit access for janitor. According to #debian-qa the
> >tool should then create merge requests instead of committing changes directly.
> >I took the liberty to downgrade the bot's role to "reporter" for the moment.
> 
> It just adds extra work for us. How many packages you are interested
> to keep in buster-backports ?

I agree with Praveen. In the vast majority of cases the Janitor changes
are useful and have no negative practical impact.

I'm pretty sure there is a way of blocking it from doing changes to the
packages where those changes are a problem for you.

Attachment: signature.asc
Description: PGP signature


Reply to: