Hi Samyak,
On 13/1/20 12:24 AM, Samyak Jain wrote:
> Hey,
>
> I've updated the Debian package of the Ruby gems asset_sync. The package
> was tested on sbuild and was successfully built. It is also
> lintian-clean. I've pushed the package to the my personal salsa repo
> which may be found at:
>
> https://salsa.debian.org/ruby-team/ruby-asset-sync
>
> This update is needed for Diaspora v0.7.12.0 and hence are required for
> completing the packaging.
>
> Requesting you to please review.
I built the package and all is well. I have, however two nitpick comments
1. Running specs generate a `coverage` directory. Clean it up as part of
`dh_clean` by adding it to a `d/clean` file
I have added a commit regarding the same.[1]
2. I personally prefer if there were one changelog entry for each major
change. For example, using debhelper-compat instead of d/compat could be
one, bumping debhelper compatibility to 12 could be another one, and
bumping Standards-Version to 4.4.1 could be another one, instead of all
of them being a single entry.
Totally agreed with your point, I have added another commit regrading it, which contains
separate entries for each major change,[2]
If you think these make sense, please make those changes and ping me,
and I will sponsor them.
Thank you so much for the guidance :D
Regards
Balu
Regards,
Samyak