[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFH: Jekyll failing reprotest in test/test_utils.rb on second run



Am Mittwoch, den 08.01.2020, 14:21 -0300 schrieb Antonio Terceiro:
> On Tue, Jan 07, 2020 at 11:19:40PM +0100, Daniel Leidert wrote:
> > Hi everybody,
> > 
> > after fixing the autopkgtest issue for jekyll there is one last issue
> > preventing a clean build on salsa.d.o. The pipeline always fails the
> > reprotest
> > job because the second run always fails the tests in test/test_utils.rb in
> > lines 349, 368, 374. The result order of Dir.glob() and Utils.safe_glob()
> > differ. This doesn't happen on the first run/build.
> > 
> > https://salsa.debian.org/ruby-team/jekyll/-/jobs/496813#L3296
> 
> The lists are the same except for ordering. Filesystem ordering is one
> of the variations that reproducible builds strategies usually employ,
> because in the wild it happens that not all filesytems produce directory
> listings with a consistent ordering. In fact, it is one of the things
> reprotest modifies in the second build.
> 
> The test suite should probably not depend on directory listings
> producing any specific ordering.

Thanks very much for your input. I've patched it so the test uses
assert_same_elements() instead of assert_equal(). Finally all CI jobs
succeeds on salsa :)

Regards, Daniel

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: