[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFP: em-proxy -- EventMachine Proxy DSL for writing high-performance transparent / intercepting proxies in Ruby



Hi Philippe,

Sorry for the delay. I've just uploaded ruby-net-dns.

I've had a look at ruby-em-proxy. The package looks fine. Just a few
details:

- to disable a test with rspec: simpler to replace it by xit instead of
  deleting the whole test

- I am not sure deleting the Gemfile.lock is necessary. Is there a
  particular reason for that?

- there is a deprecation warning when running the specs. You can fix it
  and report upstream:

Using `should` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead. Called from /<<PKGBUILDDIR>>/spec/balancing_spec.rb:25:in `block (3 levels) in <top (required)>'.



- The specs leave two processes behind, which hang the building process:

	ruby /build/ruby-em-proxy-Qdrjr2/ruby-em-proxy-0.1.9/spec/support/echo_server.rb 127.0.0.1 4242
	ruby /build/ruby-em-proxy-Qdrjr2/ruby-em-proxy-0.1.9/spec/support/echo_server.rb /tmp/em-proxy.sock

  please ensure they terminate at the end of the tests.

Best wishes,

Cédric

Attachment: signature.asc
Description: PGP signature


Reply to: