Re: [PATCH 0/2] rethinking the contents of pkg-ruby-extras.git
* Balasankar C <balasankarc@autistici.org> [160304 14:18]:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On വെള്ളി 04 മാര്ച്ച് 2016 06:31 വൈകു, Antonio Terceiro wrote:
> > After this I have made a few updates to the scripts, and all the
> > feedback I received was either "it looks good" or "I don't care",
> > so I went ahead and merged to master.
>
> I've a few doubts/suggestions regarding the scripts
>
> 1. Since quilt is often used in Ruby packages (I often use it to patch
> out usage of bundler), it would be good if that is added to the
> packages that get installed in the setup script. Patching is often
> required, anyway.
Added.
> 2. build script uses gbp buildpackage which requires the changes to be
> commited before building. But, isn't the common workflow make changes
> => check if it works by doing a build => commit changes ? It saves
> from amending the comments often. Is there any way to overcome this?
>From what I see in the script, you can just pass --git-ignore-new to
it.
Christian
--
,''`. Christian Hofstaedtler <zeha@debian.org>
: :' : Debian Developer
`. `' 7D1A CFFA D9E0 806C 9C4C D392 5C13 D6DB 9305 2E03
`-
Reply to: