[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 0/2] rethinking the contents of pkg-ruby-extras.git



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On വെള്ളി 04 മാര്‍ച്ച് 2016 06:31 വൈകു, Antonio Terceiro wrote:
> After this I have made a few updates to the scripts, and all the 
> feedback I received was either "it looks good" or "I don't care",
> so I went ahead and merged to master.

I've a few doubts/suggestions regarding the scripts

1. Since quilt is often used in Ruby packages (I often use it to patch
out usage of bundler), it would be good if that is added to the
packages that get installed in the setup script. Patching is often
required, anyway.
2. build script uses gbp buildpackage which requires the changes to be
commited before building. But, isn't the common workflow make changes
=> check if it works by doing a build => commit changes ? It saves
from amending the comments often. Is there any way to overcome this?



- -- 
Regards
Balasankar C
http://balasankarc.in
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCgAGBQJW2YsUAAoJEJbtq5sua3Fxw7IIALp/zgBJQHRgdunfqMMb3epx
ESsui3mryQvBurYEldsF5J0jfv0AyGExSdy8bzozOWFM3fFWiQezaOPeCZDsnU88
QsgwLlYojDodBF5QdHrIEZTjvgFUXJBIAi3mibVmcSrrsPDJqvyMGGHN2SrMwhKL
/s+Xeo6RCbc5YvZm9/MX0L/1avkFl1g5QnMO0jxO2lj3G5dfp1SqDdvAkVRIX/7C
xGR9tiGg8byjYxxRJe3bYQTfnk0Y7uf5zKPsw2DyEkARW++2PnltrhsYG6WTxiEB
kPDoWjhsL7lRrvyygkZihzS8O0ipgvvkjlF8YutI6l1q4ZZ9xUpgZlnyyY+vDs8=
=a0dS
-----END PGP SIGNATURE-----

Attachment: 0x2E6B7171.asc
Description: application/pgp-keys


Reply to: