[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: grit, gitlab-grit and rugged



On Mon, Dec 07, 2015 at 05:55:05PM +0530, Pirate Praveen wrote:
> Hi,
> 
> grit is unmaintained and they recommend rugged. gitlab's own libraries
> (gitlab-git) have moved to rugged, but gollum-lib depend on
> gitlab-grit (they are also planning to remove it soon [1]). Since
> gitlab depends on gollum-lib, we need gitlab-grit. As per our earlier
> consensus we should add gitlab fork's patches to original library and
> drop patches when fork is no longer required. But here that would be
> just extra work without any benefit (patching ruby-grit and patching
> gollum-lib to use grit instead of gitlab-grit).
> 
> So I propose we drop ruby-grit (there are no reverse dependencies) and
> package ruby-gitlab-grit.
> 
> Once gollum-lib drops gitlab-grit dependency, we can also drop the
> ruby-gitlab-grit package. If there are no objections, I hope to
> complete it in the next few days.
> 
> Thanks
> Praveen
> 
> [1] https://github.com/gollum/gollum-lib/issues/180

Judging from the URL above gollum supports multiple backends, including
rugged (which is just not the default). Instead of adding gitlab-grit
temporarily already expecting to remove it at some point¹, I would just
patch gollum-lib to use rugged by default and drop the dependency on
gitlab-grit (since upstream is already willing to do that anyway).

¹ i.e. wasting the time of the FTP masters

-- 
Antonio Terceiro <terceiro@debian.org>

Attachment: signature.asc
Description: PGP signature


Reply to: