On Monday 07 December 2015 05:55 PM, Pirate Praveen wrote: > Hi, > > grit is unmaintained and they recommend rugged. gitlab's own libraries > (gitlab-git) have moved to rugged, but gollum-lib depend on > gitlab-grit (they are also planning to remove it soon [1]). Since > gitlab depends on gollum-lib, we need gitlab-grit. As per our earlier > consensus we should add gitlab fork's patches to original library and > drop patches when fork is no longer required. But here that would be > just extra work without any benefit (patching ruby-grit and patching > gollum-lib to use grit instead of gitlab-grit). Looks like I missed the work already done in ruby-grit. gitlab patches are integrated already, so I'll just patch ruby-gollum-grit-adapter to use ruby-grit. > So I propose we drop ruby-grit (there are no reverse dependencies) and > package ruby-gitlab-grit. > > Once gollum-lib drops gitlab-grit dependency, we can also drop the > ruby-gitlab-grit package. If there are no objections, I hope to > complete it in the next few days. > > Thanks > Praveen > > [1] https://github.com/gollum/gollum-lib/issues/180 >
Attachment:
signature.asc
Description: OpenPGP digital signature