Hi Hleb. I reviewed the new packages to try and save Cedric some work. He has done
a lot of reviews for me and I think I know what he’s going to say. (-:
TL;DR, there are ITP bugs missing, debian/*.docs should be updated for all repos,
debian/*.examples should be updated for packages containing example code,
and DEP3 headers for submitted patches are required. (The DEP3 thing seems to
be pkg-ruby specific, and I haven’t seen it anywhere else).
On 25 Jul 2015, at 1:43 am, Hleb Valoshka <375gnu@gmail.com> wrote:
>
> New packages:
> * ruby-gssapi
Missing ITP bug number in debian/changelog
Add README.md to debian/ruby-gssapi.docs
Add examples to debian/ruby-gssapi.examples
Add DEP3 headers for debian/patches/*
> * ruby-gyoku
Missing ITP bug number in debian/changelog
Expand on long description
Add README.md to debian/ruby-gyoku.docs
Add DEP3 headers for debian/patches/*
> * ruby-little-plugger
Missing ITP bug number in debian/changelog
Add README.rdoc to debian/ruby-little-plugger.docs
Add DEP3 headers for debian/patches/*
> * ruby-nori
Missing ITP bug number in debian/changelog
Add README.rdoc to debian/ruby-little-plugger.docs
Add DEP3 headers for debian/patches/*
> * ruby-logging (after ruby-little-plugger is accepted)
Source in debian/copyright file is template
Missing ITP bug number in debian/changelog
Add README.rdoc to debian/ruby-logging.docs
Add examples to debian/ruby-logging.examples
Add DEP3 headers for debian/patches/*
This package fails to run its test suite, but only for ruby2.2:
Running tests for ruby2.2 with test file list from debian/ruby-test-files.yaml ...
RUBYLIB=/Source/pkg-ruby/ruby-logging/debian/ruby-logging/usr/lib/ruby/vendor_ruby:. ruby2.2 -ryaml -e YAML.load_file\(\"debian/ruby-test-files.yaml\"\).each\ \{\ \|f\|\ require\ f\ \}
Loaded suite -e
Started
...........................................F
===============================================================================
Failure: test_custom_numberd_filename(TestLogging::TestAppenders::TestRollingFile)
/Source/pkg-ruby/ruby-logging/test/appenders/test_rolling_file.rb:275:in `test_custom_numberd_filename'
272: ap << 'Z' * 101; ap.flush
273: files = Dir.glob(glob).sort
274: assert_equal 2, files.length
=> 275: assert_equal 'Z'*101, ::File.read(files.first)
276: assert_equal 'Y'*101, ::File.read(files.last)
277:
278: cleanup
<"ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ">(UTF-8) expected but was
<"XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX">(US-ASCII)
diff:
? ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ
? XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
? Encoding: UTF-8
? S ASCII
===============================================================================
...............................................................................
.....................................................
Finished in 8.337124233 seconds.
------
176 tests, 1096 assertions, 1 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
99.4318% passed
------
21.11 tests/s, 131.46 assertions/s
ERROR: Test "ruby2.2" failed. Exiting.
> * ruby-winrm (after all previous pakages are accepted)
Cloned an empty repository - I don’t think you pushed this because ruby-logging doesn’t build yet?
Regards,
Tim.
Attachment:
smime.p7s
Description: S/MIME cryptographic signature