[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: test-kitchen



Hi!

On Tue, Jun 30, 2015 at 10:06:57PM +0300, Hleb Valoshka wrote:
> Hi team!

> I've prepared package for integration tool for chef -- test-kitchen.

0005-Do-not-change-LOAD_PATH-and-do-not-use-rubygems-in-b.patch is
missing (it appears in the debian/patches/series file).

There is a typo in 0003-Remove-CI-staff.patch: s/staff/stuff/g in the
name of the patch and the description.

In the man page, you can shorten the description (like the short
description of the package).

Remove the capital letter in the beginning of the short description.

Have you forwarded the patch 0004-Fix-monkey-patching-of-IO.read.patch
upstream? If yes, add the info in the header of the patch.

Can you run also the Cucumber features in debian/ruby-tests.rake?

Don't you need to install the files in templates/?
For example, kitchen init fails:
Could not find "kitchen.yml.erb" in any of your source paths. Your current source paths are: 
/usr/lib/ruby/templates/init

Cheers,

Cédric

Attachment: signature.asc
Description: Digital signature


Reply to: