[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: ruby-fakefs 0.6.7-1



Hi Sebastian,

On Fri, May 01, 2015 at 10:35:04AM +0200, Sebastian Boehm wrote:
> Hi debian-ruby,

> congratulations on a great release and thanks for all of the hard work that
> went into jessie!

yeah! thanks :)

> The following package is ready to be uploaded (I also verified the
> points listed on
> http://wiki.debian.org/Teams/Ruby/Packaging#Requesting_Sponsorship).

> Could you please sponsor it?

> ruby-fakefs 0.6.7-1

The package looks fine. Thanks for the update. I've a couple of small
remarks:

You could add a: Testsuite: autopkgtest-pkg-ruby in the debian/control
file, so that the test suite can be run against the installed package on
the ci.debian.net continuous integration platform (althought the package
is already probably whitelisted).

I noticed also there is a spec/ directory, but these tests are not run
with debian/ruby-tests.rb. To run RSpec tests, the easiest way is to use
a rake task. You can write a debian/ruby-teste.rake instead of the .rb,
getting inspiration from the upstream Rakefile to recycle the two tasks
for test/ and spec/ tests.

The homepage could also be switched to https:// in debian/control and
debian/copyright.

Cheers,

Cédric

Attachment: signature.asc
Description: Digital signature


Reply to: