On Wed, Sep 17, 2014 at 01:08:20AM +0000, Potter, Tim (Cloud Services) wrote:
> I spent a fair while trying to get the test suite going, and it appears
> that it¹s necessary to have a elasticsearch server running on port 9200
> for the tests to succeed. That doesn¹t sound like something that should be
> happening as part of a package build.
> I also needed to package up about a dozen extra Ruby gems just to get the
> test suites for ruby-elasticsearch* running without import errors. Not
> sure it¹s worth the extra effort, but if that¹s policy then I can try
> and get things working and submit them for upload.
If there is a subset of tests (some unit tests?) that could run without
the elasticsearch server, you may try to run only those. If you manage
to package the dozen of gems, you could (maybe as a middle term goal) to
run the full test suite with autopkgtest.
The repository seems to miss the pristine-tar branch.
Since you seem to need dependency on ruby-elasticsearch-* for
ruby-elasticsearch with the same version, you can use (=
${source:Version}) for the version restriction in the dependency instead
of typing manually the Debian version (which is also error-prone).
And what about elastic-extensions? Is there a reason not to make a
binary package out of it?
For the documentation, since every subdirectory ships its own README,
you will need a debian/ruby-elasticsearch*.docs for each binary package.
Ship also the examples subdirectory by mentioning it in a
debian/ruby-elasticsearch.examples file.
The short description shouldn't begin with an uppercase letter with no
reason. Could you fix the one for ruby-elasticsearch-transport?
Cheers,
Cédric
Attachment:
signature.asc
Description: Digital signature