Re: RFS: ruby-fastimage

[Youhei SASAKI <uwabami@gfd-dennou.org>]

Dear Cédric,

Thanks for your review and comments.

At Wed, 27 Aug 2014 14:59:29 +0200,
Cédric Boutillier <boutil@debian.org> wrote:
> > And also, It's first time for me to use autopkgtest by gem2deb-testrunner.
> > Please check and provide comments.
>
> About debian/tests/, the Test-Command line with just:
> gem2deb-test-runner --autopkgtest 2>&1
> should be enough (in particular, no need to call/depend on quilt).
>
> Indeed, quoting /usr/share/doc/autopkgtest/README.package-tests.html:
>
> 	The cwd of each test is guaranteed to be the root of the source
> 	package, which will have been unpacked but not built.
>
> My understanding is that the patches will thus be applied as the source
> package is unpacked. Please correct me if I misunderstood this part.

OK. I don't worry about quilt push/pop.

But lintian said that:
  W: ruby-fastimage source: missing-runtime-tests-field tests
  P: ruby-fastimage source: unknown-runtime-tests-field test-command

How to handle above mentions? Is this a linitan matter?

> I also checked briefly the rest of the package, which looks great.
> I have a couple of comments:
> - instead of using a patch to import the image from the upstream
>   Git repository, maybe you can use a tarball created from tagged
>   commits on Github:
>   https://github.com/sdsykes/fastimage/releases
>   That would avoid the trouble of carrying around binary diffs.

Hmm...

Unfortunately, upstream forgot create release tag in github repo.
   Github release tag: v1.6.0
   RubyGem release: v1.6.3

I already sent request to upstream about missing fixtures. But, if we
have to avoid to use binary diff, I'll create package using github
sources with version number, e.g., 1.6.3~gitYYYYMMDD-1.

> - according to the paragraph on package descriptions in the Developers
>   reference, packaging best practices:
>   https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis
>   it is recommended to put in the synopsis a noun phrase without capital
>   letter at the beginning. I would put something like:
>   "tool to find the size or type of image using as little as needed"
>   (if it is grammatically correct).

Thanks. I'll update description.

Best Wishes,
Youhei
---
Youhei SASAKI <uwabami@gfd-dennou.org>
              <uwabami@debian.or.jp>
GPG fingerprint:
  4096/RSA: 66A4 EA70 4FE2 4055 8D6A C2E6 9394 F354 891D 7E07