On 06/08/14 05:11 AM, Cédric Boutillier wrote:
On Sun, Aug 03, 2014 at 08:52:43PM -0400, Caitlin Matos wrote:I have pushed changes to git for these 2 packages. Can someone please review them?Hi Caitlin, I uploaded ruby-htmlentities. Here are a few comments/questions about ruby-hikidoc. * you fixed the synopsis in debian/control to remove the final period. I think you should remove also the first part: "'HikiDoc' is a", according to the developer's reference 6.2.2 https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis
Done
* the manpage debian/hikidoc.1 seems automatically generated with help2man. Why not override the dh_installmanpages target in debian/rules to generate automatically this man page at build time? the repository of ruby-heckle is an example where such a thing is done.
Done. I also later realised that the syntax reference should be installed as an HTML document (otherwise it doesn't make any sense) and have updated the package.
The new document referred to an external image with an unknown licence. To avoid this, I instead included a copy of the Debian logo and made the necessary changes. However, lintian is now giving me "unused-license-paragraph-in-dep5-copyright lgpl-3.0+ (paragraph at line 53)", which is very weird, because there's a corresponding Files paragraph. I have tried manipulating the text several different ways, with no success. It's only an "info"-level problem, but it's an annoyance and I can't seem to figure it out. If you (or anyone else reading this!) notice something I haven't, let me know!
* In your patch for gemspec, shouldn't be the name of the license, * "BSD-3-clause", as in http://guides.rubygems.org/specification-reference/#license= Otherwise, it looks fine for me.
I did it this way because that's what upstream put in their new gemspec. I have now changed it and submitted a report upstream.
Cheers, Cédric
Thanks, Caitlin