On Sun, Aug 03, 2014 at 08:52:43PM -0400, Caitlin Matos wrote: > I have pushed changes to git for these 2 packages. Can someone please review > them? Hi Caitlin, I uploaded ruby-htmlentities. Here are a few comments/questions about ruby-hikidoc. * you fixed the synopsis in debian/control to remove the final period. I think you should remove also the first part: "'HikiDoc' is a", according to the developer's reference 6.2.2 https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis * the manpage debian/hikidoc.1 seems automatically generated with help2man. Why not override the dh_installmanpages target in debian/rules to generate automatically this man page at build time? the repository of ruby-heckle is an example where such a thing is done. * In your patch for gemspec, shouldn't be the name of the license, * "BSD-3-clause", as in http://guides.rubygems.org/specification-reference/#license= Otherwise, it looks fine for me. Cheers, Cédric
Attachment:
signature.asc
Description: Digital signature