Re: RFS: ruby-base62 0.1.4-1

[Thomas Bechtold <thomasbechtold@jpberlin.de>]

Hi Cédric,

On 09/10/2013 05:02 PM, Cédric Boutillier wrote:
> Here are a few comments:
> 
> * debian/changelog: replace UNRELEASED by unstable

Done.

> * debian/control: 
>   - uncomment the Vcs-* fields
>   - the "short" description is too long. At the moment, it is a mere
>     copy of the long description wrapped in one line. 
>     Try something like:
>     base62 encoding and decoding library for Ruby
>     (you can drop the "for Ruby part")

Done.

> * maybe you can ask upstream to split the license out of the README
>   file?

I'll do this.

>   Otherwise, it looks fine to me.
> 
>   It is a very small library. Is it a dependency of something else you
>   want to package?

Yes. I want to package Razor (https://github.com/puppetlabs/Razor).

Thanks for the review!

Cheers,

Tom