On Thu, Jul 04, 2013 at 12:11:34AM +0530, Nitesh A Jain wrote: > I have updated the package to the new upstream and have pushed it to the repo > http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-cassiopee.git > Please review it and consider uploading it Hi Nitesh, Thanks for your work. Here are a few comments: in debian/changelog, you still have UNRELEASED instead of unstable for the targeted suite. Changes between debian/0.1.0-1 and upstream/0.1.10 have not been documented in the changelog. Possible improvements: change copyright file to have a single License standalone paragraph extend the man page to include all options of bin/cassie install bin/demo* as examples remove README from installed docs, regarding the amount of information it contains. It can be questionable if the 0.1.10 version is worth an upload, since the only change (except metadata) is: --- a/lib/cassiopee.rb +++ b/lib/cassiopee.rb @@ -2,7 +2,6 @@ require 'digest/md5' require 'logger' require 'zlib' require 'text' -require 'text/util' Cheers, Cédric
Attachment:
signature.asc
Description: Digital signature