Hi! On Sun, Feb 24, 2013 at 06:04:35PM +0000, Christopher Baines wrote: > On 24/02/13 15:00, Cédric Boutillier wrote: > > I had a quick look at ruby-georuby: > > You should not override error about the use of rubygems in > > debian/require-rubygems.overrides. Instead, you should patch the source > > to remove these lines, and ensure that all dependencies are packaged and > > listed as such. > Ok, I have attempted to do this, and also pushed it to github [1] I had a brief look at your repo on github. It is a pity you did not save your modifications as commits on top of the original Debian packaging provided by gem2deb. It makes it more difficult to follow what you've changed. > > The commented line in debian/control (about nokogiri, etc.) is obtained > > from the gem metadata and should guide you to fill the Depends: and > > Build-Depends: field. From a quick glance, it will need as Depends: > > ruby-nokogiri, ruby-dbf (not packaged), ruby-json. ruby-rspec and rake should appear on the Build-Depends line, not the Depends line, as they are used just during tests. You must however add also on this line ruby-json, ruby-nokogiri and ruby-dbf since during the tests, ruby-georuby will be used, and so will be its dependencies. There are more issues with the debian/control file: - DM-Upload-Allowed: line should disappear - Standards-Version: should be 3.9.4 - Description could be improved: capitalize Ruby, decypher OGC, maybe add some words about these specifications. Also I can see you didn't replace the ruby-tests.rb by ruby-tests.rake as I suggested. > I think I have sorted the dependencies, but am having more trouble > packaging dbf. When I build the package, I get: > /usr/bin/ruby1.8 -I/usr/lib/ruby/vendor_ruby > /usr/lib/ruby/vendor_ruby/gem2deb/test_runner.rb > ./spec/dbf/column_spec.rb:1:in `require': no such file to load -- > spec_helper (LoadError) > from ./spec/dbf/column_spec.rb:1 > from -e:1:in `require' > from -e:1 > from -e:1:in `each' > from -e:1 > ERROR: Test "ruby1.8" failed. Exiting. > dh_auto_install: dh_ruby --install > /home/chris/Projects/Packaging/OSM/OSRM/gems/ruby-dbf-2.0.3/debian/ruby-dbf > returned exit code 1 > Now, there is a spec_helper.rb file, but its here ./spec/spec_helper.rb > , and running "rspec spec" works...? The error disappears when the file spec/spec_helper.rb is added to the list in debian/ruby-test-files.yaml. However, the tests won't run with this method. To run tests with rspec (which is the case with dbf), you should use the same technique as for ruby-georuby: - remove the debian/ruby-test-files.yaml file and add a debian/ruby-tests.rake file, with a similar content as for ruby-georuby - add rake and ruby-rspec as build-dependencies. I think it should do it. I hope it helps. Cheers, Cédric
Attachment:
signature.asc
Description: Digital signature