Re: RFS: ruby-rainbow

[Nitesh A Jain <niteshjain92@gmail.com>]

I have made the changes as recommended by Cedric and pushed them
.Please review it and let me know if there are any issues still
remaining



Thank You

Nitesh

On Mon, Jun 3, 2013 at 7:39 PM, Nitesh A Jain <niteshjain92@gmail.com> wrote:
> Thank you Cedric
> I will make the changes tomorrow as i have an exam to write
>
> On 3 Jun 2013 19:35, "Cédric Boutillier" <cedric.boutillier@gmail.com>
> wrote:
>>
>> Dear Nitesh,
>>
>> On Sun, Jun 02, 2013 at 10:48:31PM +0530, Nitesh A Jain wrote:
>> > I have made changes as recommended by Cedric and have  the pushed the
>> > changes.
>> > Also I have now moved it to git.debian.org so you can download it from
>> > there
>>
>> > git://git.debian.org/pkg-ruby-extras/ruby-rainbow.git
>>
>> > Please review it and let me know if there are any
>> > issues still remaining
>>
>>
>> Thanks for the update. When I tried to build the package in pbuilder, I
>> still got 10 failures. Looking at debian/ruby-tests.rb, I see you put a
>> general expression, as found in the boilerplate code. This is fine, but
>> as I said, since you have just *one* test file, it would be simplet to
>> put:
>>
>>      require 'test/rainbow_test'
>>
>> The test failure is caused by the fact that in pbuilder environment,
>> color is deactivated. It should be forced with an environment variable
>> (found by looking quickly at the source code). My debian/ruby-tests.rb
>> now looks like:
>>
>> ENV['CLICOLOR_FORCE']='1'
>> Dir['{spec,test}/**/*.rb'].each { |f| require f }
>>
>>
>> (the second line can be replaced by the simpler one above for the unique
>> test file)
>> Now all tests pass with ruby1.8 and ruby1.9.1. No need thus to disable
>> tests with ruby1.8 in debian/rules.
>>
>> In debian/control:
>> - According to lintian, you should use canonical URIs for Vcs-* fields:
>>   for Vcs-Browser:
>>
>> http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-rainbow.git;a=summary
>>   for Vcs-Git:
>>    git://anonscm.debian.org/pkg-ruby-extras/ruby-rainbow.git
>>
>> - The short description should not start with a capitalized letter. The
>>   long description should have a period '.' instead of a new line after
>>   ANSI terminals.
>>
>> Otherwise, I believe it is ready. Could you please implement those
>> changes ? I'll be happy to sponsor your package.
>>
>> Cheers,
>>
>> Cédric