[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ruby-mysql2 package is prepared



On 12/07/2012 10:38 PM, Cédric Boutillier wrote:
Currently, tests for packages using ruby-spec will not run using the
debian/ruby-test-files.yaml method. Please use the ruby-tests.rake
method, and don't forget to add rake as a build-dependency (see diff
attached).

Applied the patch and tests are now running much nicer.

You could patch the examples so that they do not use rubygems, and don't
modify the LOAD_PATH (the library will be installed in a place where
ruby can find it, and the relative path ../lib is not valid anymore
from /usr/share/doc/ruby-mysql2/examples).

I did that for examples, and also for the benchmarks.

The package ruby-eventmachine is a dependency of ruby-mysql2, so you
need to add it also to the Depends: field (not only Build-Depends).

Added.

Other than that, the package looks fine. I will upload it once you have
addressed the points above.

Cool. Just uploaded it to mentors. The updated git repo is here:

https://github.com/michaelfranzl/ruby-mysql2

Michael


Reply to: