Re: RFS: ruby-ncursesw 1.3.1-1

[Per Andersson <avtobiff@gmail.com>]

On Sun, Apr 8, 2012 at 8:26 AM, Cédric Boutillier
<cedric.boutillier@gmail.com> wrote:
>
> Hi Per!
>
> On Sat, Apr 07, 2012 at 08:41:34PM +0200, Per Andersson wrote:
>> Hi!
>
>> The following package are ready to be uploaded (I also verified the
>> points listed on
>> http://wiki.debian.org/Teams/Ruby/RubyExtras/RequestingSponsorship).e
>
>> Could you please sponsor it?
>
>>  ruby-ncursesw 1.3.1-1
>
> I am not DD, so I cannot upload your package. I have a few
> remarks:
> - In the short description, Ruby should be spelled with a capital 'R'.

Fixed.


> - You certainly don't need to build-depend on libncurses5-dev, since the
>  Ruby extension will be linked against libncursesw5-dev.

Fixed.


> - It is considered a best practice to use the same license for the
>  packaging as the one used for the source. Unless you have a good
>  reason, I suggest you use LGPL-2.1+ for your packaging work.

Allright, changed that.


> - If you have a patch to use the library with 1.9.1, it may be worth
>  including it, without waiting for inclusion upstream. It could
>  certainly be used with (an updated version of) ruby-ncurses also!

Ok, I included it and build for all Ruby versions.


Bumped Debian revision.

Everything pushed, please upload!


Best,
Per

> Thanks!
>
> Best regards,
>
> Cédric