Re: RFS: ruby-blankslate

[Antonio Terceiro <terceiro@debian.org>]

Marc Dequènes (Duck) escreveu isso aí:
> Coin,
> 
> Quoting Lucas Nussbaum <lucas@lucas-nussbaum.net>:
> 
> >On 04/01/12 at 19:41 -0200, Antonio Terceiro wrote:
> >>The correct solution is to make ruby-builder drop it's embedded copy of
> >>blankslate and depend on it instead. Ideally all the other embedded
> >>copies should also be dropped in favor of the standalone package.
> 
> I agree.
> 
> >I think it's OK to upload with the duplicate file, and open an RC bug
> >against ruby-builder. For the others, it's a smaller issue since the
> >private copy doesn't conflict.
> 
> Let's do this.
> 
> Btw, if someone has got an idea for #646657, just to avoid piling RC bugs…

This was reported upstream more or less 6 months ago without a solution
yet:

https://github.com/jimweirich/builder/issues/9

I would say for now, disable that test on 1.9 using something like this:

diff --git a/test/test_markupbuilder.rb b/test/test_markupbuilder.rb
index 63864ad..52a1279 100644
--- a/test/test_markupbuilder.rb
+++ b/test/test_markupbuilder.rb
@@ -451,7 +451,7 @@ class TestIndentedXmlMarkup < Test::Unit::TestCase
       xml.instruct!(:xml, :encoding => 'UTF-16')
       xml.p(encode("\xE2\x80\x99", 'UTF8'))
       assert_match(%r(<p>&#8217;</p>), xml.target!) #
-    end
+    end if RUBY_VERSION < '1.9'
 
     def test_use_utf8_if_encoding_defaults_and_kcode_is_utf8
       xml = Builder::XmlMarkup.new


-- 
Antonio Terceiro <terceiro@debian.org>

Attachment: signature.asc
Description: Digital signature