[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: gem2deb shouldn't rewrite shebangs of shell scripts



Hello Dmitry,

Dmitry Borodaenko escreveu isso aí:
> gem2deb 0.2.9 happily rewrote the shebang line of a shell script in
> /usr/bin of my package. Attached patch makes it only do that if ruby is
> mentioned anywhere in the first line of the script: if it's not, and
> there is a shebang in the line to begin with, I think it's safe to
> assume it's not a Ruby script.

Good catch, and thanks for your patch.

Before applying it I wrote a failing test to make sure we do not have
regressions in the future. You might want to check it out:

http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/gem2deb.git;a=commitdiff;h=1cf4aa00b36a50037ed5e6e771a3c157b2b866d5

It would be really nice if everyone wrote tests for their patches to
gem2deb. ;-)

-- 
Antonio Terceiro <terceiro@debian.org>

Attachment: signature.asc
Description: Digital signature


Reply to: