Hi! On Sun, Aug 14, 2011 at 07:35:53PM -0700, Antonio Terceiro wrote: > It looks like a lot of -- if not all -- files in ext/ are actually > 'Copyright (C) 2007 David L Parsons', so debian/copyrigh must have an > entry for those files. I overlooked this indeed. I updated debian/copyright to correct the copyright assignment to all files in ext/ except extconf.*, blucloth.* and Makefile. > Also, you added a patch to remove the $LOAD_PATH manipulation mess in > the tests, but you didn't enable them to run at build time: > debian/ruby-tests.rb is all commented out. The problem is that the test suite cannot run because of missing dependencies (in particular ruby-tidy). It was meant to be a preliminary step when/if the dependencies are made available. But maybe I should have not added the patches in the first place. Maybe can I just leave them in the repository and comment them in debian/patches/series? Or should I try to package the dependencies? > Other thing: you added patches that are not applied in the Git > repository, so you need to make sure they are unapplied after build > (otherwise you cannot build the package again with git-buildpackage, for > example). See for example point 2 in Raphael's tips post: > https://raphaelhertzog.com/2010/11/18/4-tips-to-maintain-a-3-0-quilt-debian-source-package-in-a-vcs/ Thanks for the reference. I made the modification. Best regards, Cédric
Attachment:
signature.asc
Description: Digital signature