Re: ruby-sinatra 1.2.6 (New Upstream)

[Youhei SASAKI <uwabami@gfd-dennou.org>]

Hi, Lucas

Thank you for your quick reply. 

At 25 Jul 2011 20:38:28 +0200,
"Lucas Nussbaum" <lucas@lucas-nussbaum.net> wrote:
> 
> On 26/07/11 at 03:02 +0900, Youhei SASAKI wrote:
> > Hi,
> > 
> > I committed "ruby-sinatra" New upstream 1.2.6 to pkg-ruby-extras Git repo.
> > 
> > However, there some problems:
> > 
> > - lintian warning:
> >   W: ruby-sinatra: image-file-in-usr-lib usr/lib/ruby/vendor_ruby/sinatra/images/404.png
> >   W: ruby-sinatra: image-file-in-usr-lib usr/lib/ruby/vendor_ruby/sinatra/images/500.png
> 
> I usually ignore them. It would require deep changes to the code to fix
> them. Maybe we should talk to the lintian team about that. I'll try to
> remember to do that.

Ok. 
 
> > - Can't running ruby-test.rb
> > 
> >   The ruby-sinatra's "test/helper.rb" require "rack/test". So I ITP
> >   "ruby-rack-test"(#635388) and create package into Git repo.
> >   However, "ruby-tack-test" package need ruby-sinatra in build time.
> >   There are circular build-dependency in upstream sources.
> 
> You can create a ruby-sinatra by disabling the test suite. Then create a
> ruby-rack-test package, building against ruby-sinatra. Then re-build
> ruby-sinatra to check the test suite.
>
> While circular dependencies are bad, they are OKish for arch:all
> packages. And we don't really have the choice anyway.

Ok, I see. 

The test of ruby-sinatra with ruby-rack-test is fine.  So I'll upload
ruby-sinatra.

Best Wishes,
---
Youhei SASAKI <uwabami@gfd-dennou.org>
              <uwabami@debian.or.jp>
GPG fingerprint:
  4096/RSA: 66A4 EA70 4FE2 4055 8D6A C2E6 9394 F354 891D 7E07