[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Ogon packaging for Debian (was: Re: Bug#906072: Ogon packages available (Linux RDP Server))



Hi Marcel, Mike,

first of sorry you haven't heard from my until now. Unfortunately I'm
quite busy with project and family work. Hope I'll be available more the
next weeks.

On Mon, Jun 29, 2020 at 07:52:03PM +0000, marcel@linux-ng.de wrote:
> > I just looked at the ogon.git again. There is a thrift tarball
> > (binary!?!) inside.
> > 
> > Can we get rid of this? It won't be accepted by Debian's ftpmasters.
There shouldn't be *any* tarball in the checked in git. But if any of
the thrift binaries or libraries isn't found (cmake/FindThrift.cmake)
ogon includes an cmake 'external project' that downloads and build
thrift. In the later case a thrift tarball will be found somewhere in
the external directory.

Ogon's core requires thirft's cpp (C++) generator. 

> The original ogon package is downloading this file during build (an compiles it afterwards).
> However, as downloading is not possible in my/most automated build environments I had to "fix" that somehow.
> 
> So if building against an external thrift package is possible I'll gladly adapt the packages to do that.
> Hints about how to manage that are welcome.
If the external project is triggered either the library or the compiler
wasn't found. This could be a missing build dependency or an error in
the FindThrift cmake file.
Any version of thrift that includes the fix for issue THRIFT-3420 should
work.

Hope it's more clear now.

Best regards,
Bernhard


Reply to: