[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1120289: trixie-pu: magit/4.3.5-1+deb13u1



Hi Johannes,

Johannes Schauer Marin Rodrigues <josch@debian.org> writes:

> Hi,
>
> Quoting Xiyue Deng (2025-11-10 14:07:28)
>> And yet, only *_amd64.buildinfo was produced even when I run "sbuild -A -s
>> --source-only-change" as suggested by the wiki[1].  What would be the correct
>> way to let sbuild generate *_source.buildinfo?
>
> the -s option to sbuild keeps causing problems. This is why in its man page it
> is currently documented like this:
>
>> -s, --source
>>     Build the source package in addition to the other requested build
>>     artifacts. By default, the dsc will not be rewritten because the source
>>     package is the input to sbuild, not its output. Even when running from an
>>     unpacked source tree sbuild will first build the source package using
>>     dpkg-source and then pass that on to the sbuild machinery. Use this option
>>     only when you know what you are doing. This will rewrite the original dsc
>>     passed to sbuild.
>
> Using the -s option with sbuild is like running "convert foo.jpg bar.png" and
> then imagemagick overwrites foo.jpg (the input). Please don't use -s. The
> wiki page you are quoting introduced the -s option 7 years ago with this
> change:
>
> https://wiki.debian.org/SourceOnlyUpload?action=diff&rev1=12&rev2=13
>
> I corrected that wiki page. Thank you for sharing where you had this from.
> Your sbuild command will do the right thing if you just omit the -s option.
>
> Thanks!
>
> cheers, josch

Thanks for the tip!  Though unfortunately dropping "-s" didn't seem to
make any difference: it still produces *_amd64.buildinfo only.  I took a
closer look at `man sbuild' and thought that this could be the default
behavior for --arch-all where it will try to build arch:all packages and
hence produced the buildinfo with the host arch (amd64).  I tried to
turn it off but it will cause the build to fail due to the following
error:

,----
| E: dsc: amd64 not in arch list or does not match any arch wildcards: all -- skipping
`----

So I guess that's probably only used for special cases (e.g. buildd)?
Anyway, I guess it's probably easier to just use "dgit push-source" or
tag2upload.

P.S. Do you think it's beneficial to also change the sbuild wiki page[1]
which also turns on --source by suggesting `$build_source = 1;'?

[1] https://wiki.debian.org/sbuild

-- 
Regards,
Xiyue Deng

Attachment: signature.asc
Description: PGP signature


Reply to: