[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1112272: marked as done (trixie-pu: package mate-sensors-applet/1.26.0-1+deb13u1)

Your message dated Sat, 06 Sep 2025 12:14:57 +0100
with message-id <165032e5317517556dd7fd8cf24843112a3fb6ac.camel@adam-barratt.org.uk>
and subject line Closing p-u requests for fixes included in 13.1
has caused the Debian Bug report #1112272,
regarding trixie-pu: package mate-sensors-applet/1.26.0-1+deb13u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1112272: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1112272
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: trixie
X-Debbugs-Cc: mate-sensors-applet@packages.debian.org
Control: affects -1 + src:mate-sensors-applet
User: release.debian.org@packages.debian.org
Usertags: pu

[ Reason ]
In trixie's version of mate-sensors-applet (1.26.0-1) applet crashes
started being observed since upload of glib 2.83.2.

[ Impact ]
mate-sensors-applet in trixie stays unusable.

[ Tests ]
Manual tests at runtime.

[ Risks ]
Minimal, only for users of mate-sensors-applet.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]

>  [ A Mennucc1 ]
>  * NMU to  fix: "Crashes on Trixie", thanks to Gleb Golubitsky
>    (Closes: #1100414).

-> Cherry-picked patch from upstream.

[ Other info ]
None.

diff -Nru mate-sensors-applet-1.26.0/debian/changelog mate-sensors-applet-1.26.0/debian/changelog
--- mate-sensors-applet-1.26.0/debian/changelog	2021-12-13 00:57:51.000000000 +0100
+++ mate-sensors-applet-1.26.0/debian/changelog	2025-08-28 08:08:51.000000000 +0200
@@ -1,3 +1,11 @@
+mate-sensors-applet (1.26.0-1+deb13u1) trixie; urgency=medium
+
+  [ A Mennucc1 ]
+  * NMU to  fix: "Crashes on Trixie", thanks to Gleb Golubitsky
+    (Closes: #1100414).
+
+ -- Mike Gabriel <sunweaver@debian.org>  Thu, 28 Aug 2025 08:08:51 +0200
+
 mate-sensors-applet (1.26.0-1) unstable; urgency=medium
 
   [ Martin Wimpress ]
diff -Nru mate-sensors-applet-1.26.0/debian/patches/Fix-an-invalid-pointer-crash-with-glib-2.83.2.patch mate-sensors-applet-1.26.0/debian/patches/Fix-an-invalid-pointer-crash-with-glib-2.83.2.patch
--- mate-sensors-applet-1.26.0/debian/patches/Fix-an-invalid-pointer-crash-with-glib-2.83.2.patch	1970-01-01 01:00:00.000000000 +0100
+++ mate-sensors-applet-1.26.0/debian/patches/Fix-an-invalid-pointer-crash-with-glib-2.83.2.patch	2025-08-28 08:08:37.000000000 +0200
@@ -0,0 +1,51 @@
+From 9b74dc16d852a40d37f7ce6c236406959fd013e5 Mon Sep 17 00:00:00 2001
+From: lukefromdc <lukefromdc@hushmail.com>
+Date: Mon, 13 Jan 2025 22:39:13 -0500
+Subject: [PATCH] Fix an invalid pointer crash with glib 2.83.2
+
+The typecast to non-const gchar produced invalid pointer errors on free() with glib 2.83.2
+---
+ plugins/udisks2/udisks2-plugin.c | 19 +++++--------------
+ 1 file changed, 5 insertions(+), 14 deletions(-)
+
+Index: mate-sensors-applet-1.26.0/plugins/udisks2/udisks2-plugin.c
+===================================================================
+--- mate-sensors-applet-1.26.0.orig/plugins/udisks2/udisks2-plugin.c
++++ mate-sensors-applet-1.26.0/plugins/udisks2/udisks2-plugin.c
+@@ -311,16 +311,15 @@ syslog(LOG_ERR, "propdict2 type: %s", g_
+ #endif
+ 
+             /* get data */
+-            gchar *id = NULL;
+-            gchar *model = NULL;
++            const gchar *id = NULL;
++            const gchar *model = NULL;
+ 
+             gboolean smartenabled;
+             gdouble temp;
+ 
+-            /* NULL, bc we don't care about the length of the string
+-             * typecast bc g_variant_get_string() returns const char* */
+-            id = (gchar *) g_variant_get_string (g_variant_lookup_value (propdict, "Id", G_VARIANT_TYPE_STRING), NULL);
+-            model = (gchar *) g_variant_get_string (g_variant_lookup_value (propdict, "Model", G_VARIANT_TYPE_STRING), NULL);
++            /* NULL, bc we don't care about the length of the string*/
++            id = g_variant_get_string (g_variant_lookup_value (propdict, "Id", G_VARIANT_TYPE_STRING), NULL);
++            model = g_variant_get_string (g_variant_lookup_value (propdict, "Model", G_VARIANT_TYPE_STRING), NULL);
+ 
+             smartenabled = g_variant_get_boolean (g_variant_lookup_value (propdict2, "SmartEnabled", G_VARIANT_TYPE_BOOLEAN));
+             temp = g_variant_get_double (g_variant_lookup_value (propdict2, "SmartTemperature", G_VARIANT_TYPE_DOUBLE));
+@@ -373,14 +372,6 @@ syslog(LOG_ERR, "No temp data for device
+ 
+                 g_debug ("No temp data for device: %s\n", key);
+             }
+-
+-#ifdef UD2PD
+-syslog(LOG_ERR, "b4 free1");
+-#endif
+-
+-            g_free (id);
+-            g_free (model);
+-
+         }
+ 
+ #ifdef UD2PD
diff -Nru mate-sensors-applet-1.26.0/debian/patches/series mate-sensors-applet-1.26.0/debian/patches/series
--- mate-sensors-applet-1.26.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ mate-sensors-applet-1.26.0/debian/patches/series	2025-08-28 08:08:37.000000000 +0200
@@ -0,0 +1 @@
+Fix-an-invalid-pointer-crash-with-glib-2.83.2.patch

--- End Message ---
--- Begin Message --- 
Package: release.debian.org
Version: 13.1

Hi,

Each of the updates referenced by these requests was included in
today's 13.1 point release for trixie.

Regards,

Adam

--- End Message ---
Reply to: