[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1108523: marked as done (unblock: tqftpserv/1.1-4)

Your message dated Mon, 07 Jul 2025 09:20:23 +0000
with message-id <E1uYi1P-00AVRY-0u@respighi.debian.org>
and subject line unblock tqftpserv
has caused the Debian Bug report #1108523,
regarding unblock: tqftpserv/1.1-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1108523: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108523
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: tqftpserv@packages.debian.org, aferraris@debian.org
Control: affects -1 + src:tqftpserv
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package tqftpserv

[ Reason ]
Removes an unneeded dependency on qrtr-ns (from package qrtr-tools) in the
included systemd service

[ Impact ]
The systemd service would be unusable unless the user manually installs qrtr-
tools

[ Tests ]
Verified the systemd service is enabled and working as expected when qrtr-tools
isn't installed

[ Risks ]
None that I can think of (trivial change, backported from upstream)

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
This upload also limits the build architectures to amd64, armhf & arm64 -- see
#1108221 (done) for the RM request for other arches

unblock tqftpserv/1.1-4

diff -Nru tqftpserv-1.1/debian/changelog tqftpserv-1.1/debian/changelog
--- tqftpserv-1.1/debian/changelog	2025-02-03 17:04:56.000000000 +0100
+++ tqftpserv-1.1/debian/changelog	2025-05-19 12:18:27.000000000 +0200
@@ -1,3 +1,18 @@
+tqftpserv (1.1-4) unstable; urgency=medium
+
+  * d/control: only build for ARMv7+
+    This package is specifically aimed at supporting hardware features of
+    modern Qualcomm SoC's, which are all ARM-based (mostly `arm64`, but that
+    includes `armhf` parts such as e.g. MSM8916). There's no point shipping
+    this package on other architectures, so limit the list to `armhf` and
+    `arm64`, while keeping `amd64` as it greatly simplifies running CI and
+    debugging builds.
+  * d/patches: backport upstream service fix.
+    The QRTR nameserver has been built into the kernel for years now, so the
+    service no longer needs to depend on `qrtr-ns.service`. (Closes: #1104039)
+
+ -- Arnaud Ferraris <aferraris@debian.org>  Mon, 19 May 2025 12:18:27 +0200
+
 tqftpserv (1.1-3) unstable; urgency=medium
 
   * d/copyright: update upstream contact
diff -Nru tqftpserv-1.1/debian/control tqftpserv-1.1/debian/control
--- tqftpserv-1.1/debian/control	2025-02-03 17:04:56.000000000 +0100
+++ tqftpserv-1.1/debian/control	2025-05-19 12:18:27.000000000 +0200
@@ -17,7 +17,7 @@
 Rules-Requires-Root: no
 
 Package: tqftpserv
-Architecture: any
+Architecture: amd64 armhf arm64
 Depends: ${misc:Depends},
          ${shlibs:Depends},
 Description: TFTP server implementation for the QRTR protocol
@@ -29,7 +29,7 @@
 Build-Profiles: <!noudeb>
 Package-Type: udeb
 Section: debian-installer
-Architecture: any
+Architecture: amd64 armhf arm64
 Depends: ${misc:Depends},
          ${shlibs:Depends},
 Description: TFTP server implementation for the QRTR protocol
diff -Nru tqftpserv-1.1/debian/patches/0002-tqftpserv.service.in-remove-dependency-on-qrtr-ns.se.patch tqftpserv-1.1/debian/patches/0002-tqftpserv.service.in-remove-dependency-on-qrtr-ns.se.patch
--- tqftpserv-1.1/debian/patches/0002-tqftpserv.service.in-remove-dependency-on-qrtr-ns.se.patch	1970-01-01 01:00:00.000000000 +0100
+++ tqftpserv-1.1/debian/patches/0002-tqftpserv.service.in-remove-dependency-on-qrtr-ns.se.patch	2025-05-19 12:18:27.000000000 +0200
@@ -0,0 +1,25 @@
+From: Nicola Guerrera <guerrera.nicola@gmail.com>
+Date: Sat, 9 Nov 2024 00:22:37 +0100
+Subject: tqftpserv.service.in: remove dependency on qrtr-ns.service
+
+QRTR is built in to the kernel now, the other packages (such as rmtfs) have since removed qrtr-ns as a service dependency
+
+Signed-off-by: Nicola Guerrera <guerrera.nicola@gmail.com>
+
+Origin: upstream commit cab8b18f9ac3c1f980e253c71f68130875f59c8e
+---
+ tqftpserv.service.in | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/tqftpserv.service.in b/tqftpserv.service.in
+index 3333e02..71a7991 100644
+--- a/tqftpserv.service.in
++++ b/tqftpserv.service.in
+@@ -1,7 +1,5 @@
+ [Unit]
+ Description=QRTR TFTP service
+-Requires=qrtr-ns.service
+-After=qrtr-ns.service
+ 
+ [Service]
+ ExecStart=@prefix@/bin/tqftpserv
diff -Nru tqftpserv-1.1/debian/patches/series tqftpserv-1.1/debian/patches/series
--- tqftpserv-1.1/debian/patches/series	2025-02-03 17:04:56.000000000 +0100
+++ tqftpserv-1.1/debian/patches/series	2025-05-19 12:18:27.000000000 +0200
@@ -1 +1,2 @@
 0001-translate-lookup-firmware-files-under-lib-firmware-u.patch
+0002-tqftpserv.service.in-remove-dependency-on-qrtr-ns.se.patch

--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: