Bug#1107344: unblock: kf6-kio/6.13.0-4
On 2025-06-06 10:06:06 +0200, Aurélien COUDERC wrote:
> Le vendredi 6 juin 2025, 08:48:01 heure d’été d’Europe centrale Sebastian Ramacher a écrit :
> > Control: tags -1 moreinfo
> >
> > On 2025-06-06 00:45:10 +0200, Aurélien COUDERC wrote:
> > > Package: release.debian.org
> > > Severity: normal
> > > X-Debbugs-Cc: kf6-kio@packages.debian.org, Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
> > > Control: affects -1 + src:kf6-kio
> > > User: release.debian.org@packages.debian.org
> > > Usertags: unblock
> > >
> > > Dear Release Team,
> > >
> > > please unblock package kf6-kio.
> > >
> > > [ Reason ]
> > > It contains the following changes:
> > > * Backport upstream commits:
> > > - Show single-click selection emblem in open/save dialogs when using
> > > single-click mouse mode. (kde#185793)
> > > - When saving a file, don’t override user provided filename with folder
> > > name when navigating inside a folder with the keyboard. (kde#502794)
> > > - Fix actions described by D-Bus activatable desktop files not being
> > > triggered when there’s no Exec key.
> > > - Inhibit suspend while there’s a file copy job running. (kde#362542)
> > > - Update symbols accordingly.
> >
> > This change removes a symbol. Why is it save to do that?
>
> Ah yes good question, I forgot to include my analysis.
> And in fact my changelog is slightly misleading, the referenced commit only adds symbols, the removal is from :
>
> > - Fix actions described by D-Bus activatable desktop files not being
> > triggered when there’s no Exec key.
>
> From upstream commit [1].
>
> This commit adds an argument to KProcessRunner::fromApplication which is documented upstream as internal. [2]
> /**
> * @internal (exported for KIO GUI job unit tests)
> * This class runs a KService or a shell command, using QProcess internally.
> * It creates a startup notification and finishes it on success or on error (for the taskbar)
> * It also shows an error message if necessary (e.g. "program not found").
> */
Okay. But note that the versions for the newly introduced symbols is not
sufficient. Since they are introduced in a patch after the first upload of
the upstream version, this version needs to be reflected in the symbols
file (with an ~ at the end for potential backports and to make lintian
happy).
Please remove the moreinfo tag once a fixed version is available in
unstable.
Cheers
--
Sebastian Ramacher
Reply to: