Bug#1107344: unblock: kf6-kio/6.13.0-4

[Aurélien COUDERC <coucouf@debian.org>]

Le vendredi 6 juin 2025, 08:48:01 heure d’été d’Europe centrale Sebastian Ramacher a écrit :
> Control: tags -1 moreinfo
> 
> On 2025-06-06 00:45:10 +0200, Aurélien COUDERC wrote:
> > Package: release.debian.org
> > Severity: normal
> > X-Debbugs-Cc: kf6-kio@packages.debian.org, Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
> > Control: affects -1 + src:kf6-kio
> > User: release.debian.org@packages.debian.org
> > Usertags: unblock
> > 
> > Dear Release Team,
> > 
> > please unblock package kf6-kio.
> > 
> > [ Reason ]
> > It contains the following changes:
> > * Backport upstream commits:
> >   - Show single-click selection emblem in open/save dialogs when using
> >   single-click mouse mode. (kde#185793)
> >   - When saving a file, don’t override user provided filename with folder
> >   name when navigating inside a folder with the keyboard. (kde#502794)
> >   - Fix actions described by D-Bus activatable desktop files not being
> >   triggered when there’s no Exec key.
> >   - Inhibit suspend while there’s a file copy job running. (kde#362542)
> >     - Update symbols accordingly.
> 
> This change removes a symbol. Why is it save to do that?

Ah yes good question, I forgot to include my analysis.
And in fact my changelog is slightly misleading, the referenced commit only adds symbols, the removal is from :

>   - Fix actions described by D-Bus activatable desktop files not being
>   triggered when there’s no Exec key.

From upstream commit [1].

This commit adds an argument to KProcessRunner::fromApplication which is documented upstream as internal. [2]
/**
 * @internal  (exported for KIO GUI job unit tests)
 * This class runs a KService or a shell command, using QProcess internally.
 * It creates a startup notification and finishes it on success or on error (for the taskbar)
 * It also shows an error message if necessary (e.g. "program not found").
 */

You can confirm with codesearch.d.n that this static method is not used outside kio :
https://codesearch.debian.net/search?q=KProcessRunner&literal=0&perpkg=1


[1] https://invent.kde.org/frameworks/kio/-/commit/31806c5180eb7cd1ad2f354eafd84f8fc490eae2
[2] https://invent.kde.org/frameworks/kio/-/blob/31806c5180eb7cd1ad2f354eafd84f8fc490eae2/src/gui/kprocessrunner_p.h#L29


Thanks,
--
Aurélien