[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1040953: bookworm-pu: package sra-sdk/3.0.3+dfsg-6~deb12u1



Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian.org@packages.debian.org
Usertags: pu
X-Debbugs-Cc: sra-sdk@packages.debian.org
Control: affects -1 + src:sra-sdk

[ Reason ]
Per #1039621, the new libngs-jni package accidentally wound up with
bad content (unexpanded variables in the key symlink's source *and*
target) that rendered it useless.

[ Impact ]
This package's reverse dependencies, from libngs-java on up, will be
broken unless libncbi-ngs-dev happens to be installed.

[ Tests ]
Various affected packages have autopkgtests, but they evidently missed
the relevant bug, having presumably wound up running with
libncbi-ngs-dev additionally installed.  (The tests did catch the
need for architecture restrictions that made it into bookworm, FWIW.)

[ Risks ]
Minimal -- trivial fix, working in testing and unstable with no
further changes from stable.

[ Checklist ]
  [*] *all* changes are documented in the d/changelog
  [v] I reviewed all changes and I approve them
  [v] attach debdiff against the package in (old)stable
  [v] the issue is verified as fixed in unstable

[ Changes ]
Tweak debian/rules to make the necessary substitutions in
libngs-java.links.in.

[ Other info ]
In reviewing the debdiff, I see that one of my teammates pushed a
debian/salsa-ci.yml update without a corresponding changelog note that
consequently slipped into -6 undocumented; what should I do about it
at this point?

I've held off on cleaning up a long-dangling symlink in a different
binary package (sra-toolkit, #1040391) but can readily throw that in
if you'd like.
diff -Nru sra-sdk-3.0.3+dfsg/debian/.gitignore sra-sdk-3.0.3+dfsg/debian/.gitignore
--- sra-sdk-3.0.3+dfsg/debian/.gitignore	2023-02-24 05:52:27.000000000 -0500
+++ sra-sdk-3.0.3+dfsg/debian/.gitignore	1969-12-31 19:00:00.000000000 -0500
@@ -1,16 +0,0 @@
-*.debhelper
-*.substvars
-.debhelper
-.javahelper_clean
-debhelper-build-stamp
-files
-lib*-dev
-lib*[0-9]
-libngs-java
-libngs-java-doc
-libngs-java-doc.doc-base.javadoc
-libngs-jni
-libngs-jni.links
-python3-ngs
-sra-toolkit
-tmp
diff -Nru sra-sdk-3.0.3+dfsg/debian/changelog sra-sdk-3.0.3+dfsg/debian/changelog
--- sra-sdk-3.0.3+dfsg/debian/changelog	2023-02-24 05:52:27.000000000 -0500
+++ sra-sdk-3.0.3+dfsg/debian/changelog	2023-07-12 22:20:14.000000000 -0400
@@ -1,3 +1,16 @@
+sra-sdk (3.0.3+dfsg-6~deb12u1) bookworm; urgency=medium
+
+  * Reupload to bookworm (stable).  (Closes: #10nnnnn).
+
+ -- Aaron M. Ucko <ucko@debian.org>  Wed, 12 Jul 2023 22:20:14 -0400
+
+sra-sdk (3.0.3+dfsg-6) unstable; urgency=high
+
+  * debian/rules: Expand $(DEB_HOST_MULTIARCH) in libngs-java.links.in.
+    (Closes: #1039621.)
+
+ -- Aaron M. Ucko <ucko@debian.org>  Tue, 27 Jun 2023 22:14:41 -0400
+
 sra-sdk (3.0.3+dfsg-5) unstable; urgency=medium
 
   * Limit libngs-java to those architectures where libs are available
diff -Nru sra-sdk-3.0.3+dfsg/debian/rules sra-sdk-3.0.3+dfsg/debian/rules
--- sra-sdk-3.0.3+dfsg/debian/rules	2023-02-24 05:52:27.000000000 -0500
+++ sra-sdk-3.0.3+dfsg/debian/rules	2023-07-12 22:19:10.000000000 -0400
@@ -152,7 +152,10 @@
 execute_before_dh_link:
 	# Putting the upstream version number (without the dfsg part) at the end of
 	# symlink source in the -jni package.
-	sed 's/\(#STRIPPED_UPSTREAM_VERSION#\)/\1$(DEB_VERSION_UPSTREAM)/; s/#STRIPPED_UPSTREAM_VERSION#\(.*\)+dfsg[0-9]*/\1/' debian/libngs-jni.links.in > debian/libngs-jni.links
+	sed -e 's/\(#STRIPPED_UPSTREAM_VERSION#\)/\1$(DEB_VERSION_UPSTREAM)/' \
+	    -e 's/#STRIPPED_UPSTREAM_VERSION#\(.*\)+dfsg[0-9]*/\1/' \
+	    -e 's/\$$[({]DEB_HOST_MULTIARCH[)}]/$(DEB_HOST_MULTIARCH)/g' \
+	    debian/libngs-jni.links.in > debian/libngs-jni.links
 
 # require network, not automatically run
 # use it when the pom file must be re-downloaded from maven repo
diff -Nru sra-sdk-3.0.3+dfsg/debian/salsa-ci.yml sra-sdk-3.0.3+dfsg/debian/salsa-ci.yml
--- sra-sdk-3.0.3+dfsg/debian/salsa-ci.yml	2023-02-24 05:52:27.000000000 -0500
+++ sra-sdk-3.0.3+dfsg/debian/salsa-ci.yml	2023-07-12 22:19:10.000000000 -0400
@@ -2,3 +2,7 @@
 include:
   - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
   - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml
+
+variables:
+# Does not build on i386
+  SALSA_CI_DISABLE_BUILD_PACKAGE_I386: 1

Reply to: