[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1035593: marked as done (unblock: kwin/4:5.27.2-2)

Your message dated Sat, 6 May 2023 08:07:03 +0200
with message-id <cc18af16-b88d-b05b-0daa-0b3ec51960c7@debian.org>
and subject line Re: Bug#1035593: unblock: kwin/4:5.27.2-2
has caused the Debian Bug report #1035593,
regarding unblock: kwin/4:5.27.2-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1035593: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035593
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: kwin@packages.debian.org, hefee@debian.org
Control: affects -1 + src:kwin

Please unblock package kwin

[ Reason ]
Fix 1033212. For limba phones kwin is not usable at all, with that fix
it is usable again.

[ Impact ]
Plasma mobile is not usable on limba phones.

[ Tests ]
Marco Mattiolo, the author of the patch for kwin, tested it on their
devices.

[ Risks ]
The patch is very simple and straightforward. For me it seems not very
likly that it has bad outcome for other users. On experimental there is
also kwin 5.27.3 with that patch included and that is also tested be a
bunch of people.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
You do a great work and you are very fast responding ;)

unblock kwin/4:5.27.2-2

diff -Nru kwin-5.27.2/debian/changelog kwin-5.27.2/debian/changelog
--- kwin-5.27.2/debian/changelog	2023-02-28 15:01:10.000000000 +0100
+++ kwin-5.27.2/debian/changelog	2023-05-05 14:22:35.000000000 +0200
@@ -1,3 +1,12 @@
+kwin (4:5.27.2-2) unstable; urgency=medium
+
+  * Team upload.
+
+  [ Marco Mattiolo ]
+  * Backport patch to fix kwin for Lima (Pinephone) (Closes: #1033212)
+
+ -- Sandro Knauß <hefee@debian.org>  Fri, 05 May 2023 14:22:35 +0200
+
 kwin (4:5.27.2-1) unstable; urgency=medium
 
   [ Aurélien COUDERC ]
diff -Nru kwin-5.27.2/debian/patches/fix-for-Lima-disabling-GLSL.patch kwin-5.27.2/debian/patches/fix-for-Lima-disabling-GLSL.patch
--- kwin-5.27.2/debian/patches/fix-for-Lima-disabling-GLSL.patch	1970-01-01 01:00:00.000000000 +0100
+++ kwin-5.27.2/debian/patches/fix-for-Lima-disabling-GLSL.patch	2023-05-05 14:16:46.000000000 +0200
@@ -0,0 +1,47 @@
+From 64d682a646d111a0250bbe3bff77ef0cead91403 Mon Sep 17 00:00:00 2001
+From: Hannah Kiekens <hannahkiekens@gmail.com>
+Date: Tue, 28 Feb 2023 21:04:37 +0000
+Subject: [PATCH] Enable GLSL for Mali (Lima) / PinePhone devices
+
+Commit 88cf8355 changed the behaviour of Mali (Lima) / PinePhone devices by disabling GLSL
+88cf8355 got backported in 5.27.1 and broke PinePhone devices (White rectangle on topright quarter of a black screen)
+
+This patch restores the behaviour of 5.27.0
+
+
+(cherry picked from commit 0543949df709c69c99c46c9abad483250b01c288)
+---
+ .../libkwineffects/data/glplatform/lima-mali400-desktop-3.0    | 2 +-
+ src/libkwineffects/kwinglplatform.cpp                          | 3 +--
+ 2 files changed, 2 insertions(+), 3 deletions(-)
+
+diff --git a/autotests/libkwineffects/data/glplatform/lima-mali400-desktop-3.0 b/autotests/libkwineffects/data/glplatform/lima-mali400-desktop-3.0
+index 8e32a85af81..cf83810fd8b 100644
+--- a/autotests/libkwineffects/data/glplatform/lima-mali400-desktop-3.0
++++ b/autotests/libkwineffects/data/glplatform/lima-mali400-desktop-3.0
+@@ -6,7 +6,7 @@ ShadingLanguageVersion=1.30
+ 
+ [Settings]
+ LooseBinding=true
+-GLSL=false
++GLSL=true
+ TextureNPOT=true
+ Mesa=true
+ Lima=true
+diff --git a/src/libkwineffects/kwinglplatform.cpp b/src/libkwineffects/kwinglplatform.cpp
+index 82554ca755b..aa0f5b105a5 100644
+--- a/src/libkwineffects/kwinglplatform.cpp
++++ b/src/libkwineffects/kwinglplatform.cpp
+@@ -1138,8 +1138,7 @@ void GLPlatform::detect(OpenGLPlatformInterface platformInterface)
+ 
+     if (isLima()) {
+         m_recommendedCompositor = OpenGLCompositing;
+-        // GLSL works but causes dramatic FPS drop on this GPU
+-        m_supportsGLSL = false;
++        m_supportsGLSL = true;
+     }
+ 
+     if (isVideoCore4()) {
+-- 
+GitLab
+
diff -Nru kwin-5.27.2/debian/patches/series kwin-5.27.2/debian/patches/series
--- kwin-5.27.2/debian/patches/series	2022-10-02 18:15:15.000000000 +0200
+++ kwin-5.27.2/debian/patches/series	2023-05-05 14:16:46.000000000 +0200
@@ -1 +1,2 @@
 uninitialized-yuvformat.patch
+fix-for-Lima-disabling-GLSL.patch

--- End Message ---
--- Begin Message --- 
Hi,

On 05-05-2023 23:17, Hefee wrote:

unblock kwin/4:5.27.2-2


done.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


--- End Message ---
Reply to: