Package: release.debian.org User: release.debian.org@packages.debian.org Usertags: unblock Severity: normal Please unblock package liferea [ Reason ] The version of liferea in bullseye is susceptible to bug 990911 where the application can crash if the user select a specific element (news bin) in the GUI. What's worse, if a news bin was the last selected item before upgrading, it will then automatically crash on startup with no way for the user to recover, except by downgrading. [ Impact ] Program crashes, or fails to start after upgrade. [ Tests ] I verified manually that I can trigger the crash with the version in bullseye and that the crash doesn't happen with the patch from upstream applied. [ Risks ] The patch is small and is a move of three lines of existing code to inside an if(). I'd say the risk is small. The patch comes from upstream (and is nearly a year ago). [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing unblock liferea/1.13.5-3 Paul
diff -Nru liferea-1.13.5/debian/changelog liferea-1.13.5/debian/changelog
--- liferea-1.13.5/debian/changelog 2021-04-27 20:27:39.000000000 +0200
+++ liferea-1.13.5/debian/changelog 2021-07-11 21:37:39.000000000 +0200
@@ -1,3 +1,10 @@
+liferea (1.13.5-3) unstable; urgency=medium
+
+ [ Frédéric Brière ]
+ * Add 0001-Fix-crash-on-selecting-news-bins.patch (Closes: #990911)
+
+ -- Paul Gevers <elbrus@debian.org> Sun, 11 Jul 2021 21:37:39 +0200
+
liferea (1.13.5-2) unstable; urgency=medium
* Add patch to work with latest webgit2gkt:
diff -Nru liferea-1.13.5/debian/patches/0001-Fix-crash-on-selecting-news-bins.patch liferea-1.13.5/debian/patches/0001-Fix-crash-on-selecting-news-bins.patch
--- liferea-1.13.5/debian/patches/0001-Fix-crash-on-selecting-news-bins.patch 1970-01-01 01:00:00.000000000 +0100
+++ liferea-1.13.5/debian/patches/0001-Fix-crash-on-selecting-news-bins.patch 2021-07-11 21:37:39.000000000 +0200
@@ -0,0 +1,43 @@
+From dd9ede21cd822989e9fafecadefb4fc410a7c0e7 Mon Sep 17 00:00:00 2001
+From: Lars Windolf <lars.windolf@gmx.de>
+Date: Fri, 2 Apr 2021 01:22:24 +0200
+Subject: [PATCH] Fix crash on selecting news bins
+
+---
+ src/feed.c | 11 ++++++-----
+ 1 file changed, 6 insertions(+), 5 deletions(-)
+
+diff --git a/src/feed.c b/src/feed.c
+index 585ed82a..97848f9f 100644
+--- a/src/feed.c
++++ b/src/feed.c
+@@ -165,9 +165,14 @@ feed_add_xml_attributes (nodePtr node, xmlNodePtr feedNode)
+ xmlNewTextChild (feedNode, NULL, "feedId", node_get_id (node));
+ xmlNewTextChild (feedNode, NULL, "feedTitle", node_get_title (node));
+
+- if (node->subscription)
++ if (node->subscription) {
+ subscription_to_xml (node->subscription, feedNode);
+
++ tmp = g_strdup_printf("%d", node->subscription->error);
++ xmlNewTextChild(feedNode, NULL, "error", tmp);
++ g_free(tmp);
++ }
++
+ tmp = g_strdup_printf("%d", node->available?1:0);
+ xmlNewTextChild(feedNode, NULL, "feedStatus", tmp);
+ g_free(tmp);
+@@ -178,10 +183,6 @@ feed_add_xml_attributes (nodePtr node, xmlNodePtr feedNode)
+
+ if(feed->parseErrors && (strlen(feed->parseErrors->str) > 0))
+ xmlNewTextChild(feedNode, NULL, "parseError", feed->parseErrors->str);
+-
+- tmp = g_strdup_printf("%d", node->subscription->error);
+- xmlNewTextChild(feedNode, NULL, "error", tmp);
+- g_free(tmp);
+ }
+
+ xmlDocPtr
+--
+2.30.2
+
diff -Nru liferea-1.13.5/debian/patches/series liferea-1.13.5/debian/patches/series
--- liferea-1.13.5/debian/patches/series 2021-04-27 20:27:39.000000000 +0200
+++ liferea-1.13.5/debian/patches/series 2021-07-11 21:37:39.000000000 +0200
@@ -1,3 +1,4 @@
debian-example-feeds.patch
www-browser.patch
34d26be00328a68d2f1625c78b54dc168da0648e.patch
+0001-Fix-crash-on-selecting-news-bins.patch
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature