[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#991738: marked as done (unblock: gdcm/3.0.8-2 (pre-approval))

Your message dated Mon, 2 Aug 2021 08:03:28 +0200
with message-id <CAM8zJQu1u4G7NS8FN1O8mQM5tGiHwBBCCeLAmK7vz9_0iimiMw@mail.gmail.com>
and subject line Re: Bug#991738: unblock: gdcm/3.0.8-2 (pre-approval)
has caused the Debian Bug report #991738,
regarding unblock: gdcm/3.0.8-2 (pre-approval)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
991738: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991738
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hello Release Team,

Please unblock package gdcm

This is a pre-approval request, because I am waiting for a
double check of my test results, and there are notorious CPU
cycles hogs in the queue.  I hope to be able to upload this
evening UTC+0200.

[ Reason ]
libgdcm-dev, a binary package from the source package gdcm, is
affected by the serious bug #989296; this update ought to
address it.

[ Impact ]
gdcm has more than ten thousand installations reported by
popcon.  libgdcm-dev has numerous reverse dependencies, and
reverse build dependencies.  A removal might seriously cripple
the distribution, as it might pull out a handful of Gnome
components, scientific and medical imaging tools, or OpenCV and
related packages.

[ Tests ]
The package has been tested against the default Salsa CI:
  * lintian fails on errors unrelated to the present change:
    E: gdcm source: invalid-profile-name-in-build-profiles-field nocil
  * the package building is known to not be reproducible to day;
  * otherwise all jobs went alright.

I tried to make sure my change did not impede the buildability
of libgdcm-dev reverse build dependencies, nor their
autopkgtest.  So far, I have not seen any build failure when
testing all reverse dependencies in Testing, and none of the few
failure in autopkgtest I could witness were actual regressions.
The test below have been double checked against the version in
the debdiff attached:

Build   Tests   Package (remark)
------  ------  ----------------
[ OK ]  [NONE]  actiona
[ OK ]  [ OK ]  beads
[ OK ]  [ OK ]  caffe
[ OK ]  [ OK ]  camitk
[ OK ]  [(OK)]  cheese (superficial)
[ OK ]  [NONE]  cimg
[ OK ]  [NONE]  darknet
[ OK ]  [NONE]  digikam
[ OK ]  [NONE]  elastix
[ OK ]  [NONE]  empathy
[ OK ]  [NONE]  eviacam
[ OK ]  [ OK ]  freecad
[ OK ]  [NONE]  ginkgocadx
[ OK ]  [NONE]  gmic
[ OK ]  [NONE]  gnome-contacts
[ OK ]  [NONE]  gnome-control-center
[ OK ]  [NONE]  gnome-dvb-daemon
[ OK ]  [NONE]  gnome-initial-setup
[ OK ]  [NONE]  gnome-sound-recorder
[ OK ]  [NONE]  gst-plugins-bad1.0
[ OK ]  [NONE]  gst-rtsp-server1.0
[ OK ]  [FAIL]  gstreamer-editing-services1.0 (unhandled autodep8-python3, not a regression)
[ OK ]  [NONE]  gstreamer-vaapi
[ OK ]  [ OK ]  opencv
[ OK ]  [NONE]  sight
[ OK ]  [NONE]  insighttoolkit4

The tests below have been verified against a slightly different
version which was deemed uncorrect while discussing the issue in
bug #989296.  They are pending a second verification at the time
of writing this unblock request:

Build   Tests   Package (remark)
------  ------  ----------------
[ OK ]  [ OK ]  auto-multiple-choice (autopkgtest needs writable home)
[ OK ]  [NONE]  itksnap
[ OK ]  [NONE]  kylin-scanner
[ OK ]  [(OK)]  monado (superficial)
[ OK ]  [NONE]  mrpt
[ OK ]  [NONE]  nifti2dicom
[ OK ]  [ OK ]  node-opencv
[ OK ]  [ OK ]  octave-dicom
[ OK ]  [NONE]  opencfu
[ OK ]  [FAIL]  openimageio (unhandled autodep8-python3, not a regression)
[ OK ]  [NONE]  orthanc-gdcm
[ OK ]  [NONE]  os-autoinst
[ OK ]  [NONE]  otb
[ OK ]  [NONE]  php-facedetect
[ OK ]  [NONE]  pitivi
[ OK ]  [NONE]  plastimatch
[ OK ]  [NONE]  pragha
[ OK ]  [NONE]  pulseeffects
[ OK ]  [ OK ]  pytorch
[ OK ]  [NONE]  qimgv
[ OK ]  [ OK ]  ros-image-pipeline
[ OK ]  [(OK)]  ros-opencv-apps (superficial)
[ OK ]  [(OK)]  ros-vision-opencv (superficial)
[ OK ]  [NONE]  sayonara
[ OK ]  [NONE]  siril
[ OK ]  [NONE]  slowmovideo
[ OK ]  [NONE]  uprightdiff
[ OK ]  [ OK ]  visp (must run against version 3.3.0-5+d1 and not 3.3.0-5)
[ OK ]  [(OK)]  vtk-dicom (superficial)

[ Risks ]
gdcm is a quite complex package.  libgdcm-dev has 5 reverse
dependencies and more than 50 reverse build dependencies.  I
estimate risks related to gdcm upload to be much higher than the
average unblock request, hence the extensive test report.  That
being said, the change is very targeted.

[ Checklist ]
  [*] all changes are documented in the d/changelog
  [*] I reviewed all changes and I approve them
  [*] attach debdiff against the package in testing

[ Other info ]
I'm sorry for the change in a package of that magnitude this
late in the release cycle.  Thank you very much for your titan
work on releasing Debian 11!

unblock gdcm/3.0.8-2

Have a nice day,  :)
-- 
Étienne Mollier <emollier@emlwks999.eu>
Fingerprint:  8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
Sent from /dev/pts/3, please excuse my verbosity.

diff -Nru gdcm-3.0.8/debian/changelog gdcm-3.0.8/debian/changelog
--- gdcm-3.0.8/debian/changelog	2020-12-17 20:30:50.000000000 +0100
+++ gdcm-3.0.8/debian/changelog	2021-07-31 10:32:44.000000000 +0200
@@ -1,3 +1,12 @@
+gdcm (3.0.8-2) unstable; urgency=medium
+
+  * Team upload.
+  * d/rules: adjust GDCMTargets-*.cmake to detect libvtkgdcmsharpglue.so and
+    vtkgdcmPython.cpython-*-*.so properly.
+    Closes: #989296
+
+ -- Étienne Mollier <emollier@debian.org>  Sat, 31 Jul 2021 10:32:44 +0200
+
 gdcm (3.0.8-1) unstable; urgency=medium
 
   [ Gert Wollny ]
diff -Nru gdcm-3.0.8/debian/rules gdcm-3.0.8/debian/rules
--- gdcm-3.0.8/debian/rules	2020-12-17 20:30:50.000000000 +0100
+++ gdcm-3.0.8/debian/rules	2021-07-28 17:13:00.000000000 +0200
@@ -54,6 +54,7 @@
 	dh $@ $(WITH_CLI) --with python3 --with javahelper  --buildsystem=cmake+ninja
 
 PYVER 	 := $(shell py3versions -dv)
+PV	 := $(shell echo $(PYVER) | sed 's/\.//')
 PYMODDIR := /usr/lib/$(shell py3versions -d)
 VTKVERS=$(shell apt-cache policy libvtk7-dev | grep "Installed:" | cut -d: -f2 | cut -d' ' -f2 | cut -d- -f1 | cut -d. -f1-2)
 
@@ -114,6 +115,11 @@
 	sed -i -e "s/FATAL_ERROR/STATUS/g" obj-*/CMake/ExportConfiguration/CMakeFiles/Export/lib/$(DEB_HOST_MULTIARCH)/gdcm-*/GDCMTargets-*.cmake
 	# See #711214
 	sed -i -e "s/FATAL_ERROR/STATUS/g" obj-*/CMake/ExportConfiguration/CMakeFiles/Export/lib/$(DEB_HOST_MULTIARCH)/gdcm-*/GDCMTargets.cmake
+	# See #989296
+	sed -i -e 's@/lib/\(.\+\)/libvtkgdcmsharpglue.so@/lib/cli/vtkgdcm-sharp-3.0/libvtkgdcmsharpglue.so@' \
+		obj-*/CMake/ExportConfiguration/CMakeFiles/Export/lib/$(DEB_HOST_MULTIARCH)/gdcm-*/GDCMTargets-*.cmake
+	sed -i -e 's@/lib/python/dist-packages/vtkgdcmPython.so@/lib/python3/dist-packages/vtkgdcmPython.cpython-$(PV)-$(DEB_HOST_MULTIARCH).so@' \
+		obj-*/CMake/ExportConfiguration/CMakeFiles/Export/lib/$(DEB_HOST_MULTIARCH)/gdcm-*/GDCMTargets-*.cmake
 
 	dh_auto_install
 	# PHP

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Unblocked.

--- End Message ---
Reply to: