Bug#989506: unblock: lutris/0.5.8.3-2
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: stephanlachnit@debian.org
Please unblock package lutris
[ Reason ]
This fixes an issue appearing with Python 3.9 in a part of the program.
Without this fix, the program will crash when this code is executed due to a
deprecated call.
Python 3.9 is the version shipped in bullseye.
[ Impact ]
The user might experience a crash.
[ Tests ]
No automatic tests cover this part of the code.
The code was not manually tested since I don't have the files required to test
it.
[ Risks ]
The risk of this change is very low.
The package is a end-user package with no reverse dependencies.
The code change is trivial (one line).
The code change follows the recommend new code for the deprecated code
according to the Python documentation [1].
[ Checklist ]
[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing
[ Other info ]
Closes #989474
unblock lutris/0.5.8.3-2
Regards,
Stephan
[1]
https://docs.python.org/3.8/library/xml.etree.elementtree.html#xml.etree.ElementTree.Element.getchildren
diff -Nru lutris-0.5.8.3/debian/changelog lutris-0.5.8.3/debian/changelog
--- lutris-0.5.8.3/debian/changelog 2021-01-23 12:45:21.000000000 +0100
+++ lutris-0.5.8.3/debian/changelog 2021-06-05 19:59:53.000000000 +0200
@@ -1,3 +1,9 @@
+lutris (0.5.8.3-2) unstable; urgency=medium
+
+ * Fix compatibility with Python 3.9 (Closes: #989474)
+
+ -- Stephan Lachnit <stephanlachnit@protonmail.com> Sat, 05 Jun 2021 19:59:53 +0200
+
lutris (0.5.8.3-1) unstable; urgency=medium
* New upstream version 0.5.8.3
diff -Nru lutris-0.5.8.3/debian/patches/0001-fix-python3_9.patch lutris-0.5.8.3/debian/patches/0001-fix-python3_9.patch
--- lutris-0.5.8.3/debian/patches/0001-fix-python3_9.patch 1970-01-01 01:00:00.000000000 +0100
+++ lutris-0.5.8.3/debian/patches/0001-fix-python3_9.patch 2021-06-05 19:59:53.000000000 +0200
@@ -0,0 +1,16 @@
+From: 6d6178667269747a <https://github.com/6d6178667269747a>
+Description: Fix Python 3.9 compatibility
+Origin: upstream, https://github.com/lutris/lutris/pull/3430/commits/8ac18d594c72d40308899e775868d49f2e4d98bd
+Applied-Upstream: yes
+Bug-Debian: http://bugs.debian.org/989474
+--- a/lutris/util/wine/cabinstall.py
++++ b/lutris/util/wine/cabinstall.py
+@@ -124,7 +124,7 @@
+ arch = self.get_arch_from_manifest(root)
+ registry_keys = root.findall("{urn:schemas-microsoft-com:asm.v3}registryKeys")
+ if registry_keys:
+- for registry_key in registry_keys[0].getchildren():
++ for registry_key in list(registry_keys[0]):
+ key = self.process_key(registry_key.attrib["keyName"])
+ out += "[%s]\n" % key
+ for reg_value in registry_key.findall("{urn:schemas-microsoft-com:asm.v3}registryValue"):
diff -Nru lutris-0.5.8.3/debian/patches/series lutris-0.5.8.3/debian/patches/series
--- lutris-0.5.8.3/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ lutris-0.5.8.3/debian/patches/series 2021-06-05 19:59:53.000000000 +0200
@@ -0,0 +1 @@
+0001-fix-python3_9.patch
Reply to: