On Tue, Jun 01, 2021 at 10:09:44PM +0200, Paul Gevers wrote: > Control: tags -1 moreinfo > > Hi Julian, > > Sorry it took so long to reply; pre-approvals are regularly awkward. > > On Mon, 17 May 2021 17:07:08 +0200 Julian Andres Klode <jak@debian.org> > wrote: > > Please unblock package apt > > Can you elaborate how severe do you think these issues are? I mean, I > guess you were in doubt if they qualify for the freeze policy (typically > if the maintainer doubts, the update doesn't qualify). Or were there > different reasons why you didn't just upload and ask for a regular unblock? My understanding is that release team prefers pre-approvals for more complex uploads in key packages where it's not just one RC bug being fixed or well "it's how we always do it, except for emergency hotfixes". > > To me it seems: We also found out that the JSON hooks are being installed by snapd, so people with that installed might actually see bugs, though we haven't seen them before (not sure why it works :D). > * The EOF could be a real thing, but the bug was reported by you and > only found during testing. Is this a regression or has it long been there? It's been there forever, but it's not triggered in testing before for unknown reasons. It's making it harder for me to > * TLS handshake is nice to have (for consistency). It's vital to ensure people get sensible re > * phased policy isn't a thing in Debian, so not relevant AFAICT Not at the moment, but the fix doesn't hurt us either, and would allow us (or people deploying Debian w/ custom repos) to make use of it in the future. > > I'm tempted to NACK. It seems we have another more important bug in file quoting reported on IRC today that can break downloads from repos that used to work if they contained "special" characters: https://salsa.debian.org/apt-team/apt/-/merge_requests/175 I've not looked into it much yet. Would you be tempted to NACK those small bug fixes (they are after all, except for JSON, all single or two line logic or return value fixes) if they accompanied the more critical bug fix? Also not sure if we want all of those 3 commits or just the first one. I can look into it in detail on Monday. -- debian developer - deb.li/jak | jak-linux.org - free software dev ubuntu core developer i speak de, en
Attachment:
signature.asc
Description: PGP signature