Bug#944190: release.debian.org: Allow britney to consider installability of dependencies of essential packages
Niels,
On Sun, Nov 10, 2019 at 10:49:00AM +0000, Niels Thykier wrote:
> I looking forward to your test case as it will make this issue a lot
> easier to debug.
A test case is attached. It fails without the patch I submitted (inadequate
though it is, as you pointed out), but succeeds with it. I hope it is helpful
and I have not missed something.
> What is supposed to happen is that:
>
> * Britney "should" rewrite the relation on "libsystemd0" as
> "libsystemd0 | libelogin0" when building the BinaryPackageUniverse
> (actually as libsystemd0/<version>/arch | libsystemd0/<version>/arch
> tuples).
>
> - This is also based on the assumption that the Conflicts/Provides
> setup in libelogin0 is done correctly. I /think/ it is - I am just
> being explicit about the assumption.
I think so too. Certainly the binaries from src:elogind are manually installable
into bullseye and satisfy the necessary dependencies of essential packages.
Thanks very much for looking at this.
Let me know if there is anything else I can do to help.
Mark
>From e7e78b251beaba5182377a15f6af226ccf950710 Mon Sep 17 00:00:00 2001
From: Mark Hindley <mark@hindley.org.uk>
Date: Sun, 10 Nov 2019 17:16:34 +0000
Subject: [PATCH] Test case for #944190.
The test requires that a dependency of an essential package can be satisfied by
another package which Provides it.
---
t/bug-944190/description | 2 ++
t/bug-944190/expected | 5 +++++
t/bug-944190/expected-excuses.yaml | 29 ++++++++++++++++++++++++++++
t/bug-944190/var/data/testing/Packages_i386 | 15 ++++++++++++++
t/bug-944190/var/data/testing/Sources | 5 +++++
t/bug-944190/var/data/unstable/Packages_i386 | 25 ++++++++++++++++++++++++
t/bug-944190/var/data/unstable/Sources | 11 +++++++++++
7 files changed, 92 insertions(+)
create mode 100644 t/bug-944190/description
create mode 100644 t/bug-944190/expected
create mode 100644 t/bug-944190/expected-excuses.yaml
create mode 100644 t/bug-944190/var/data/testing/Packages_i386
create mode 100644 t/bug-944190/var/data/testing/Sources
create mode 100644 t/bug-944190/var/data/unstable/Packages_i386
create mode 100644 t/bug-944190/var/data/unstable/Sources
diff --git a/t/bug-944190/description b/t/bug-944190/description
new file mode 100644
index 0000000..54418fd
--- /dev/null
+++ b/t/bug-944190/description
@@ -0,0 +1,2 @@
+Test case for ensuring a package with Conflicts/Provides/Replaces can satisfy a
+dependency of essential set.
diff --git a/t/bug-944190/expected b/t/bug-944190/expected
new file mode 100644
index 0000000..c249f4b
--- /dev/null
+++ b/t/bug-944190/expected
@@ -0,0 +1,5 @@
+test 1.0-1 i386
+libtest1 1.0-1 i386
+test-src 1.0-1 source
+libprovider1 1.0-1 i386
+provider 1.0-1 source
diff --git a/t/bug-944190/expected-excuses.yaml b/t/bug-944190/expected-excuses.yaml
new file mode 100644
index 0000000..9ea638c
--- /dev/null
+++ b/t/bug-944190/expected-excuses.yaml
@@ -0,0 +1,29 @@
+generated-date: 2018-12-28 22:32:22.868333
+sources:
+- excuses:
+ - Cannot be tested by piuparts (not a blocker) - (no link yet)
+ is-candidate: true
+ item-name: provider
+ maintainer: The R-Team
+ migration-policy-verdict: PASS
+ new-version: 1.0-1
+ old-version: '-'
+ policy_info:
+ age:
+ age-requirement: 10
+ current-age: 17892
+ verdict: PASS
+ autopkgtest:
+ verdict: PASS
+ build-depends:
+ verdict: PASS
+ piuparts:
+ test-results: cannot-be-tested
+ verdict: PASS
+ rc-bugs:
+ shared-bugs: []
+ unique-source-bugs: []
+ unique-target-bugs: []
+ verdict: PASS
+ reason: []
+ source: provider
diff --git a/t/bug-944190/var/data/testing/Packages_i386 b/t/bug-944190/var/data/testing/Packages_i386
new file mode 100644
index 0000000..d6cec70
--- /dev/null
+++ b/t/bug-944190/var/data/testing/Packages_i386
@@ -0,0 +1,15 @@
+Package: test
+Section: devel
+Architecture: i386
+Source: test-src
+Maintainer: The R-Team <debian-release@lists.debian.org>
+Version: 1.0-1
+Depends: libtest1
+Essential: yes
+
+Package: libtest1
+Section: devel
+Architecture: i386
+Source: test-src
+Maintainer: The R-Team <debian-release@lists.debian.org>
+Version: 1.0-1
diff --git a/t/bug-944190/var/data/testing/Sources b/t/bug-944190/var/data/testing/Sources
new file mode 100644
index 0000000..cfd24bb
--- /dev/null
+++ b/t/bug-944190/var/data/testing/Sources
@@ -0,0 +1,5 @@
+Package: test-src
+Binary: test, libtest1
+Version: 1.0-1
+Section: devel
+Maintainer: The R-Team <debian-release@lists.debian.org>
diff --git a/t/bug-944190/var/data/unstable/Packages_i386 b/t/bug-944190/var/data/unstable/Packages_i386
new file mode 100644
index 0000000..ff60b43
--- /dev/null
+++ b/t/bug-944190/var/data/unstable/Packages_i386
@@ -0,0 +1,25 @@
+Package: test
+Source: test-src
+Version: 1.0-1
+Maintainer: The R-Team <debian-release@lists.debian.org>
+Depends: libtest1
+Architecture: i386
+Section: devel
+Essential: yes
+
+Package: libtest1
+Source: test-src
+Version: 1.0-1
+Maintainer: The R-Team <debian-release@lists.debian.org>
+Architecture: i386
+Section: devel
+
+Package: libprovider1
+Source: provider
+Version: 1.0-1
+Maintainer: The R-Team <debian-release@lists.debian.org>
+Architecture: i386
+Section: devel
+Provides: libtest1
+Conflicts: libtest1
+Breaks: libtest1
diff --git a/t/bug-944190/var/data/unstable/Sources b/t/bug-944190/var/data/unstable/Sources
new file mode 100644
index 0000000..f270387
--- /dev/null
+++ b/t/bug-944190/var/data/unstable/Sources
@@ -0,0 +1,11 @@
+Package: test-src
+Binary: test, libtest1
+Version: 1.0-1
+Maintainer: The R-Team <debian-release@lists.debian.org>
+Section: devel
+
+Package: provider
+Binary: libprovider1
+Version: 1.0-1
+Maintainer: The R-Team <debian-release@lists.debian.org>
+Section: devel
--
2.11.0
Reply to: