[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#944190: release.debian.org: Allow britney to consider installability of dependencies of essential packages



Hi Mark

Thanks for the investigative work and the patch.

I have not had time to review the patch yet in details and hope to have
a look this weekend.

Could I convince you to add a small test case for this problem to our
britney2-tests repo (https://salsa.debian.org/debian/britney2-tests)
that fails with the current master but succeeds with your patch?  This
would ensure we do not inadvertently regress on this area when
refactoring code.

The overall work flow for creating a test is basically:

   # 1. Create the test (I think basic-essential-overapprox or
   # basic-essential-pseudo-uninst/test-data might be good/related
   # starting points for your case).
   $ cp -a t/<existing-test>  t/bug-944190

   # 2. Edit test data
   $ $EDITOR t/bug-944190/expected* t/bug-944190/expected/var/data/*/* \
     t/bug-944190/description

   # 3. Run the test
   $ rm -fr test-out
   $ t/runtests </path/to/britney2/britney.py> t test-out bug-944190

   # Rinse and repeat 2+3 until test behaves as expected.

For marking the test as a known failure, you can copy the following file
into the test "t/basic-essential-uninst/test-data"

Thanks,
~Niels


Reply to: