[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#928090: marked as done (unblock: ipywidgets/6.0.0-4)

Your message dated Sun, 28 Apr 2019 07:44:00 +0000
with message-id <bd9bb228-1f51-25ab-b724-8d3b96b2aa7f@thykier.net>
and subject line Re: Bug#928090: unblock: ipywidgets/6.0.0-4
has caused the Debian Bug report #928090,
regarding unblock: ipywidgets/6.0.0-4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
928090: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=928090
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi there,

I'd like to request the unblock of ipywidgets, please.  The current
package in buster FTBFS due to a small JavaScript issue (RC bug #926802)
in the build system of the package..  The patch below fixes the problem;
I'm a member of the Python team, and can upload the fix if
approved/needed.

Thanks,

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

diff --git a/debian/changelog b/debian/changelog
index e19e631..0ab3d10 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+ipywidgets (6.0.0-4) unstable; urgency=medium
+
+  * Team upload.
+  * Use 'Object.prototype' instead of 'path.scope.getBindings' when
+    calling 'hasOwnProperty'.  (Closes: #926802)
+
+ -- Sergio Durigan Junior <sergiodj@debian.org>  Sat, 27 Apr 2019 15:18:56 -0400
+
 ipywidgets (6.0.0-3) unstable; urgency=medium
 
   [ Ondřej Nový ]
diff --git a/debian/fakewebpack-postprocess.js b/debian/fakewebpack-postprocess.js
index e7f7dbc..8126eef 100755
--- a/debian/fakewebpack-postprocess.js
+++ b/debian/fakewebpack-postprocess.js
@@ -127,7 +127,7 @@ var transform = function transform(ast, fn, moduleList) {
               && injectGlobalsReplace.hasOwnProperty(path.node.name)
               && (parent.type !== 'MemberExpression' || parent.object === path.node)
               && (parent.type !== 'Property' || parent.value === path.node)) {
-                if (!path.scope.getBindings().hasOwnProperty(path.node.name)) {
+                if (!Object.prototype.hasOwnProperty.call(path.scope.getBindings(), path.node.name)) {
                     injectGlobals.push(path.node.name);
                 }
             }

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Sergio Durigan Junior:
> Control: tags -1 - moreinfo
> 
> [...]
> 
> Thanks, I've just uploaded it and it's been accepted into unstable.
> 
> Cheers,
> 

Unblocked, thanks.
~Niels

--- End Message ---
Reply to: